From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756243Ab0FYPeK (ORCPT ); Fri, 25 Jun 2010 11:34:10 -0400 Received: from kroah.org ([198.145.64.141]:36442 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248Ab0FYPeJ (ORCPT ); Fri, 25 Jun 2010 11:34:09 -0400 Date: Fri, 25 Jun 2010 08:27:27 -0700 From: Greg KH To: Michal Nazarewicz Cc: linux-usb@vger.kernel.org, David Brownell , Kyungmin Park , Marek Szyprowski , linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: gadget: g_fs: code cleanup Message-ID: <20100625152727.GB11840@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 25, 2010 at 04:29:27PM +0200, Michal Nazarewicz wrote: > This commit cleans the g_fs gadget hopefully making it more > readable. This is achieved by usage of the usb_string_ids_tab() > function for batch string IDs registration as well as > generalising configuration so that a single routine is > used to add each configuration and bind interfaces. As an > effect, the code is shorter and has fewer #ifdefs. > > Moreover, in some circumstances previous code #defined > CONFIG_USB_FUNCTIONFS_GENERIC macro to prevent a situation > where gadget with no configurations is built. This code removes > the #define form source code and achieves the same effect using > select in Kconfig. > > This patch also changes wording and names of the Kconfig options. > > Signed-off-by: Michal Nazarewicz > Signed-off-by: Kyungmin Park > --- > I believe this was overlooked so I am resending this patch again. Please always cc: me on patches you want applied, otherwise I very easily overlook them due to the very large amount of email I get. thanks, greg k-h