Re: [PATCH] Packet hub driver of Topcliff PCH

[Randy Dunlap <randy.dunlap@oracle.com>]

On Wed, 30 Jun 2010 16:51:30 +0900 Masayuki Ohtak wrote:

> Hi Andy and Andrew
> 
> I have modified for your comments.
> Please confirm below.
> 
> ---
> 
> 
> Packet hub driver of Topcliff PCH
> 
> Topcliff PCH is the platform controller hub that is going to be used in
> Intel’s upcoming general embedded platform. All IO peripherals in
> Topcliff PCH are actually devices sitting on AMBA bus. Packet hub is
> a special converter device in Topcliff PCH that translate AMBA transactions
> to PCI Express transactions and vice versa. Thus packet hub helps present
> all IO peripherals in Topcliff PCH as PCIE devices to IA system.
> Topcliff PCH have MAC address and Option ROM data.
> These data are in SROM which is connected to PCIE bus.
> Packet hub driver of Topcliff PCH can access MAC address and Option ROM data in
> SROM.
> 
> Signed-off-by: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
> Acked-by: Arnd <Arnd’s email address>

It's listed in the MAINTAINERS file.  Please use that.


> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index e023682..1851e97 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -4,6 +4,16 @@
>  
>  menu "Character devices"
>  
> +config PCH_PHUB
> +	tristate "PCH PHUB"
> +	depends on PCI
> +	help
> +	  Topcliff is a IOH for x86 embedded processor. This IOH is quite

	           is an IOH for x86 embedded processors.

> +	  different with the traditional IOH. Topcliff is a kind of ARM-based

	            from

> +	  processor and connected with PCIe bus (from x86 processor).
> +	  PHUB work as a gateway transform the PCIe transaction into the AMBA

	       works as a gateway to transform

> +	  transaction, and vise verse, and have several transform windows also.

	                   vice versa, and has several



Maybe lose some acromyns?  Overall, this help text should be about
*what* PCH_PHUB is, not *how* it accomplishes its work.
If you want to document *how* it works, put that into the source code
or Documentation/ somewhere.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***