From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757562Ab0GAAHN (ORCPT ); Wed, 30 Jun 2010 20:07:13 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:47965 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755448Ab0GAAHG (ORCPT ); Wed, 30 Jun 2010 20:07:06 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Minchan Kim Subject: Re: [PATCH 02/11] oom: oom_kill_process() doesn't select kthread child Cc: kosaki.motohiro@jp.fujitsu.com, LKML , linux-mm , Andrew Morton , David Rientjes , KAMEZAWA Hiroyuki In-Reply-To: <20100630135503.GA15644@barrios-desktop> References: <20100630182715.AA4B.A69D9226@jp.fujitsu.com> <20100630135503.GA15644@barrios-desktop> Message-Id: <20100701085011.DA13.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Thu, 1 Jul 2010 09:07:02 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Wed, Jun 30, 2010 at 06:27:52PM +0900, KOSAKI Motohiro wrote: > > Now, select_bad_process() have PF_KTHREAD check, but oom_kill_process > > doesn't. It mean oom_kill_process() may choose wrong task, especially, > > when the child are using use_mm(). > > Is it possible child is kthread even though parent isn't kthread? Usually unhappen. but crappy driver can do any strange thing freely. As I said, oom code should have conservative assumption as far as possible.