mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: James.Bottomley@suse.de, axboe@kernel.dk, hch@lst.de,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 0/2] use q->prep_rq_fn for flush requests instead of q->prepare_flush_fn()
Date: Fri, 2 Jul 2010 03:52:48 -0400	[thread overview]
Message-ID: <20100702075248.GB21266@infradead.org> (raw)
In-Reply-To: <1278056005-25438-1-git-send-email-fujita.tomonori@lab.ntt.co.jp>

On Fri, Jul 02, 2010 at 04:33:23PM +0900, FUJITA Tomonori wrote:
> We could kill q->prepare_flush_fn(). Except for ide, all the users
> just mark flush requests. They can use REQ_FLUSH flag instead. Ide can
> do like SCSI.

Yes, and I think you should go all the way to kill it instead of
keeping both APIs around.  Otherwise the patchset looks good to me.


  parent reply	other threads:[~2010-07-02  7:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02  7:33 FUJITA Tomonori
2010-07-02  7:33 ` [PATCH 1/2] block: introduce REQ_FLUSH flag FUJITA Tomonori
2010-07-02  7:33 ` [PATCH 2/2] scsi: build flush requests via q->prep_rq_fn FUJITA Tomonori
2010-07-02  7:39 ` [PATCH 0/2] use q->prep_rq_fn for flush requests instead of q->prepare_flush_fn() FUJITA Tomonori
2010-07-02  7:52 ` Christoph Hellwig [this message]
2010-07-02  7:53   ` Jens Axboe
2010-07-02  7:56     ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100702075248.GB21266@infradead.org \
    --to=hch@infradead.org \
    --cc=James.Bottomley@suse.de \
    --cc=axboe@kernel.dk \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®