From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg@redhat.com>,
Thomas Renninger <trenn@suse.de>,
Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] acer-wmi: fix memory leaks in wmab_execute error path
Date: Fri, 9 Jul 2010 21:53:55 +0100 [thread overview]
Message-ID: <201007092153.55715.carlos@strangeworlds.co.uk> (raw)
In-Reply-To: <1278647475.26099.2.camel@mola>
On Friday 09 July 2010 04:51:15 Axel Lin wrote:
> When acpi_evaluate_object() is passed ACPI_ALLOCATE_BUFFER,
> the caller must kfree the returned buffer if AE_OK is returned.
>
> Call Trace:
> wmab_execute
> -> wmi_evaluate_method
> -> acpi_evaluate_object
>
> Thus if callers of wmab_execute() pass ACPI_ALLOCATE_BUFFER,
> the return buffer must be kfreed if wmab_execute return AE_OK.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
--
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
prev parent reply other threads:[~2010-07-09 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 3:51 Axel Lin
2010-07-09 20:53 ` Carlos Corbacho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007092153.55715.carlos@strangeworlds.co.uk \
--to=carlos@strangeworlds.co.uk \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome