From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: linux-kernel@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com,
Anuj Aggarwal <anuj.aggarwal@ti.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2] regulator: tps6507x: allow driver to use DEFDCDC{2,3}_HIGH register
Date: Mon, 12 Jul 2010 11:40:45 +0100 [thread overview]
Message-ID: <20100712104045.GE21840@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1278930888-26810-1-git-send-email-nsekhar@ti.com>
On Mon, Jul 12, 2010 at 04:04:46PM +0530, Sekhar Nori wrote:
> +
> + /* Does DCDC high or the low register defines output voltage? */
> + bool defdcdc_high;
This should probably be "defdcdc_default" or something. Presumably the
line can also be wired to a GPIO and changed at runtime (otherwise the
feature seems at best odd) and if support for that is implemented then
this will change from being a static configuration in the platform data
to something configured dynamically so the name would no longer make
sense.
next prev parent reply other threads:[~2010-07-12 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 10:34 Sekhar Nori
2010-07-12 10:40 ` Mark Brown [this message]
2010-07-12 10:49 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712104045.GE21840@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anuj.aggarwal@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®