mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Takashi Iwai <tiwai@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: Modpost error after changing CONFIG_SOUND from m to y
Date: Mon, 12 Jul 2010 19:28:47 +0200	[thread overview]
Message-ID: <20100712172847.GA17423@merkur.ravnborg.org> (raw)
In-Reply-To: <AANLkTin88f83UV4HcqKtaXS7F2hMTe8YVJPpE-XLmo5J@mail.gmail.com>

On Mon, Jul 12, 2010 at 07:11:47PM +0200, Denys Vlasenko wrote:
> On Mon, Jul 12, 2010 at 7:03 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > On Mon, 12 Jul 2010 05:54:16 +0200 Denys Vlasenko wrote:
> >> I was using the same .config for my home machine for a long time,
> >> updating it using "make oldconfig" every time I moved to newer kernel.
> >> It worked fine for many kernels.
> >>
> >> In this .config I had CONFIG_SOUND=m.
> >>
> >> Starting witn 2.6.34, build fails with
> >>
> >> sound/core/sound_oss.c:25:2: error: #error "Enable the OSS soundcore multiplexer (CONFIG_SOUND) in the kernel."
> >>
> >> Ok. I changed CONFIG_SOUND to y. Now the build fails at modpost:
> >
> > Hi,
> > I can't get the build to fail (2.6.34 or 2.6.35-rc4-git4).
> > Please provide a full/complete .config file (and that will include a
> > kernel version number :).
> 
> I found out that build only fails if I give empty CFLAGS_KERNEL
> and CFLAGS_MODULE variables to make, like this:
> 
> make CFLAGS_KERNEL="" CFLAGS_MODULE=""

Messing around with kernel internal flags is bound to give
unpredictable bugs.

I this case you loose "-DMODULE" and I guess some sound specificmodules
test on this symbol.
And there may be other subtle side-effects.

What is the intial reason why you assign CFLAGS_KERNEL and CFLAGS_MODULE?

	Sam

  reply	other threads:[~2010-07-12 17:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-12  3:54 Denys Vlasenko
2010-07-12 17:03 ` Randy Dunlap
2010-07-12 17:11   ` Denys Vlasenko
2010-07-12 17:28     ` Sam Ravnborg [this message]
2010-07-12 17:33       ` Denys Vlasenko
2010-07-12 17:41         ` Sam Ravnborg
2010-07-12 17:42           ` Denys Vlasenko
2010-07-12 18:26             ` Sam Ravnborg
2010-07-26 10:35               ` Michal Marek
2010-07-12 17:40       ` Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100712172847.GA17423@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=tiwai@suse.de \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®