Re: [PATCH 2/3] regulator: add support for regulators on the ab8500 MFD

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Tue, Jul 13, 2010 at 11:51:29AM +0530, Sundar Iyer wrote:

> + * @mask: mask to enable/disable regulator
> + * @enable: enable bits to enable the regulator

Presumably these two will always be identical?

> + * @typical_voltages: typical supported voltage table

Why typical - might the set of supported values change, and if they do
how will that be detected and handled?

> +	ret = ab8500_read(info->ab8500, info->update_reg);
> +	if (ret < 0)
> +		dev_dbg(rdev_get_dev(rdev),
> +			"couldnt read 0x%x register\n", info->update_reg);
> +
> +	if (ret & info->mask)
> +		return true;
> +	else
> +		return false;

This should return the error code if the read failed.

> +static int ab8500_get_best_voltage_index(struct regulator_dev *rdev,
> +		int min_uV, int max_uV)
> +{
> +	struct ab8500_regulator_info *info = rdev_get_drvdata(rdev);
> +	int i;
> +
> +	/* check the supported voltage */
> +	for (i = 0; i < info->voltages_len; i++) {
> +		if ((info->typical_voltages[i] >= min_uV) &&
> +			(info->typical_voltages[i] <= max_uV))
> +			return i;

The indentation here is confusing - the second line of the if () is
aligned with the return statement not the first line.

> +	/* get the appropriate voltages within the range */
> +	ret = ab8500_get_best_voltage_index(rdev, min_uV, max_uV);
> +	if (ret < 0) {
> +		dev_dbg(rdev_get_dev(rdev),
> +				"coudlnt get best voltage for regulator\n");
> +	}

Should return an error here.

> +	/* set the registers for the request */
> +	ret = ab8500_set_bits(info->ab8500, info->voltage_reg,
> +				info->voltage_mask, ret);
> +	if (ret < 0) {
> +		dev_dbg(rdev_get_dev(rdev),
> +		"couldnt set voltage reg for regulator\n");
> +		return -EINVAL;

Should return the error you got back from set_bits() to provide maximum
information to the caller (besides, this isn't an invalid value - it's
an I/O issue).

> +static int ab8500_fixed_get_voltage(struct regulator_dev *rdev)
> +{
> +	int regulator_id;
> +	struct ab8500_regulator_info *info = rdev_get_drvdata(rdev);
> +
> +	regulator_id = rdev_get_id(rdev);
> +	if (regulator_id >= AB8500_NUM_REGULATORS)
> +		return -EINVAL;
> +
> +	return info->fixed_uV;
> +}
> +
> +static struct regulator_ops ab8500_ldo_fixed_ops = {
> +	.enable		= ab8500_regulator_enable,
> +	.disable	= ab8500_regulator_disable,
> +	.is_enabled	= ab8500_regulator_is_enabled,
> +	.get_voltage	= ab8500_fixed_get_voltage,
> +};

Should have list_voltage() support also ideally.