From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935217Ab0GPB34 (ORCPT ); Thu, 15 Jul 2010 21:29:56 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:51968 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935193Ab0GPB3y (ORCPT ); Thu, 15 Jul 2010 21:29:54 -0400 Date: Thu, 15 Jul 2010 18:30:10 -0700 (PDT) Message-Id: <20100715.183010.193726592.davem@davemloft.net> To: joseph.kogut@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Drivers: net: 8139cp: Fixed 28 style errors, and 119 warnings. From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Besides the feedback given by Jeff Garzik, I would like to ask that you please post your patches in a format other than as a binary attachment. Plain text attachments are fine, for example. That way your patch will be properly logged and tracked in patchwork, and be easier for people to reply to and comment upon. Thank you.