mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Conke Hu <conke.hu@gmail.com>
Cc: CoffBeta <coffbeta@gmail.com>,
	"David Brownell" <dbrownell@users.sourceforge.net>,
	gregkh@suse.de, "inux kernel" <linux-kernel@vger.kernel.org>,
	ext-jani.1.nikula@nokia.com,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: tq 2440
Date: Thu, 15 Jul 2010 17:35:26 +0100	[thread overview]
Message-ID: <20100715163526.GJ29322@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTil8GE1OguyAfp3XgfJvEmH98yNrlvGAx684a-qL@mail.gmail.com>

On Thu, Jul 15, 2010 at 11:16:30PM +0800, Conke Hu wrote:
> ever notice to the following kernel log?
> "Device 's3c2440-nand' does not have a release() function, it is
> broken and must."
> release() function should be implemented  in the platform_device.

That's not telling you to provide a release function.  The warning is
telling you that a device is being unregistered which doesn't have a
release function.

Consider this point - maybe it doesn't have a release function because
it's not supposed to be unregistered?

> > ------------[ cut here ]------------
> > WARNING: at fs/sysfs/dir.c:463 sysfs_add_one+0x30/0x44()
> > sysfs: duplicate filename 'dm9000.0' can not be created

This is the cause of the problem.  You're registering two dm9000.0
devices.  That's illegal, and it then causes all these:

> > WARNING: at drivers/base/core.c:122 device_release+0x6c/0x78()
> > Device 's3c24xx_led.3' does not have a release() function, it is broken and mus.
> > WARNING: at drivers/base/core.c:122 device_release+0x6c/0x78()
> > Device 's3c24xx_led.2' does not have a release() function, it is broken and mus.
> > WARNING: at drivers/base/core.c:122 device_release+0x6c/0x78()
> > Device 's3c24xx_led.1' does not have a release() function, it is broken and mus.
> > WARNING: at drivers/base/core.c:122 device_release+0x6c/0x78()
> > Device 's3c24xx_led.0' does not have a release() function, it is broken and mus.
> > WARNING: at drivers/base/core.c:122 device_release+0x6c/0x78()
> > Device 's3c2440-nand' does not have a release() function, it is broken and must.
...

Fix the first problem (which is the real one) and you won't have these
other problems (which aren't actually a problem.)

  reply	other threads:[~2010-07-15 16:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01  2:31 CoffBeta
2010-07-15 15:16 ` Conke Hu
2010-07-15 16:35   ` Russell King - ARM Linux [this message]
2010-07-15 16:51     ` Greg KH
2010-07-15 17:10       ` Russell King - ARM Linux
2010-07-15 17:22         ` Greg KH
2010-07-15 17:33           ` Russell King - ARM Linux
2010-07-15 20:51             ` Greg KH
2010-07-15 21:09               ` Russell King - ARM Linux
2010-07-16  8:55                 ` Greg KH
2010-07-16  9:07                   ` Russell King - ARM Linux
2010-07-16  5:40     ` Conke Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100715163526.GJ29322@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=coffbeta@gmail.com \
    --cc=conke.hu@gmail.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=ext-jani.1.nikula@nokia.com \
    --cc=gregkh@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®