From: Andy Isaacson <adi@hexapodia.org>
To: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Jens Axboe <jens.axboe@oracle.com>,
Masami Hiramatsu <mhiramat@redhat.com>
Subject: [PATCH 0/2] blktrace: startup / shutdown race fixes
Date: Thu, 15 Jul 2010 10:19:37 -0700 [thread overview]
Message-ID: <20100715171937.GA12953@hexapodia.org> (raw)
I ran into the stale-block-directory problem while using blktrace,
and while chasing it noticed the open-coded cmpxchg.
The unlink-on-final-close is a longstanding bug that's triggerable
by the standard blktrace(1) utility (it races child threads against
the parent), and should go to -stable. The cmpxchg is a startup
race that may be easy to maliciously trigger from userspace, but
is unlikely to be triggered accidentally. (Famous last words...)
Andy Isaacson (2):
blktrace: use cmpxchg
blktrace: unlink blk directory on final trace close
kernel/trace/blktrace.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
next reply other threads:[~2010-07-15 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 17:19 Andy Isaacson [this message]
2010-07-15 17:20 ` [PATCH 1/2] blktrace: use cmpxchg Andy Isaacson
2010-07-15 17:20 ` [PATCH 2/2] blktrace: unlink blk directory on final trace close Andy Isaacson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715171937.GA12953@hexapodia.org \
--to=adi@hexapodia.org \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®