From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Margarita Olaya Cabrera <magi.olaya@ti.com>,
Jorge Eduardo Candelaria <jorge.candelaria@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] twl6040: fix wrong kfree in twl6040_remove and twl6040_codec_remove
Date: Fri, 16 Jul 2010 10:36:25 +0100 [thread overview]
Message-ID: <20100716093625.GD18376@sirena.org.uk> (raw)
In-Reply-To: <1279272408.2594.1.camel@mola>
On Fri, Jul 16, 2010 at 05:26:48PM +0800, Axel Lin wrote:
> Memory allocation part:
> We allocate a memory in twl6040_codec_probe():
> priv = kzalloc(sizeof(struct twl6040_data), GFP_KERNEL);
> twl6040_codec = codec = &priv->codec;
Could you please try to take on board the feedback you were given
yesterday about this sort of stuff? Both the feedback about formatting
your patch so it's easy to apply and the collisions with other, more
substantial, work that's going on?
next prev parent reply other threads:[~2010-07-16 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 9:26 Axel Lin
2010-07-16 9:36 ` Mark Brown [this message]
2010-07-16 9:54 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716093625.GD18376@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=jorge.candelaria@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=magi.olaya@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®