From: Scott Wood <scottwood@freescale.com>
To: Anton Vorontsov <avorontsov@mvista.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Tyser <ptyser@xes-inc.com>,
linux-kernel@vger.kernel.org, Dave Jiang <djiang@mvista.com>,
linuxppc-dev@ozlabs.org,
Doug Thompson <dougthompson@xmission.com>
Subject: Re: [PATCH v2] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers
Date: Fri, 16 Jul 2010 15:12:24 -0500 [thread overview]
Message-ID: <20100716151224.21d499a3@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <20100715182507.GA3482@oksana.dev.rtsoft.ru>
On Thu, 15 Jul 2010 22:25:07 +0400
Anton Vorontsov <avorontsov@mvista.com> wrote:
> Simply add proper IDs into the device table.
>
> Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
> ---
>
> It appears that the driver has two device ID tables. :-)
> So, my previous attempt enabled only half of the functionality.
>
> Andrew,
>
> Can you please replace
>
> edac-mpc85xx-add-support-for-mpc8569-edac-controllers.patch
>
> with this patch? It also adds some more IDs for the newer chips.
>
> Thanks!
>
> drivers/edac/mpc85xx_edac.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 52ca09b..3820879 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -646,8 +646,12 @@ static struct of_device_id mpc85xx_l2_err_of_match[] = {
> { .compatible = "fsl,mpc8555-l2-cache-controller", },
> { .compatible = "fsl,mpc8560-l2-cache-controller", },
> { .compatible = "fsl,mpc8568-l2-cache-controller", },
> + { .compatible = "fsl,mpc8569-l2-cache-controller", },
> { .compatible = "fsl,mpc8572-l2-cache-controller", },
> + { .compatible = "fsl,p1020-l2-cache-controller", },
> + { .compatible = "fsl,p1021-l2-cache-controller", },
> { .compatible = "fsl,p2020-l2-cache-controller", },
> + { .compatible = "fsl,p4080-l2-cache-controller", },
L2 on the p4080 is quite different from those other chips. It's part
of the core, controlled by SPRs.
-Scott
next prev parent reply other threads:[~2010-07-16 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:25 Anton Vorontsov
2010-07-16 20:12 ` Scott Wood [this message]
2010-07-21 22:39 ` Andrew Morton
2010-07-21 23:21 ` Scott Wood
2010-08-01 10:54 ` [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) Anton Vorontsov
2010-10-07 6:18 ` Kumar Gala
2010-10-07 6:29 ` Anton Vorontsov
2010-10-07 6:37 ` Kumar Gala
2010-10-07 7:00 ` Kumar Gala
2010-10-07 7:12 ` Anton Vorontsov
2010-10-07 13:21 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716151224.21d499a3@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@mvista.com \
--cc=djiang@mvista.com \
--cc=dougthompson@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ptyser@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®