From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966201Ab0GPUy6 (ORCPT ); Fri, 16 Jul 2010 16:54:58 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:47079 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754961Ab0GPUy5 (ORCPT ); Fri, 16 Jul 2010 16:54:57 -0400 Date: Fri, 16 Jul 2010 21:54:45 +0100 From: Russell King - ARM Linux To: Milton Miller Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Martin Michlmayr , Woody Suwalski , Andrew Morton Subject: Re: [PATCH] Stop ARM boards crashing when CUPS is loaded - 2.6.35-rc5 Message-ID: <20100716205445.GA28064@n2100.arm.linux.org.uk> References: <4C408BEF.1060302@canonical.com> <4C3C72C6.4000005@canonical.com> <20100715130214.4c9303b2.akpm@linux-foundation.org> <20100715200618.GA6773@n2100.arm.linux.org.uk> <4C40218A.4090806@canonical.com> <20100716092018.GB16995@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 16, 2010 at 02:38:38PM -0500, Milton Miller wrote: > I just looked at the 8250 code and it abuses the platform device model. > Instead of a platform device for each port, it has multiple port > descriptions set via platform_data in one or a a few device instances. I don't agree with that assessment (but then I'm the one who created that.) Having one platform device for each port would have been absurd given the number of ISA addresses that 8250 ports appear at. Who'd want 64+ platform devices for serial ports?