From: David Miller <davem@davemloft.net>
To: sbhatewara@vmware.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
pv-drivers@vmware.com, ronghua@vmware.com, matthieu@vmware.com
Subject: Re: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [4/5] Do not reset when the device is not opened
Date: Sat, 17 Jul 2010 16:35:38 -0700 (PDT) [thread overview]
Message-ID: <20100717.163538.137865264.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LRH.2.00.1007160108240.12503@localhost.localdomain>
From: Shreyas Bhatewara <sbhatewara@vmware.com>
Date: Fri, 16 Jul 2010 01:17:29 -0700 (PDT)
>
>
> On Thu, 15 Jul 2010, David Miller wrote:
>
>> From: Shreyas Bhatewara <sbhatewara@vmware.com>
>> Date: Thu, 15 Jul 2010 18:20:52 -0700 (PDT)
>>
>> > Is this what you suggest :
>> >
>> > ---
>> >
>> > Hold rtnl_lock to get the right link state.
>>
>> It ought to work, but make sure that it is legal to take the
>> RTNL semaphore in all contexts in which this code block
>> might be called.
>>
>
> This code block is called only from the workqueue handler, which runs in
> process context, so it is legal to take rtnl semaphore.
> Tested this code by simulating event interrupts (which schedule this
> code) at considerable frequency while the interface was brought up and
> down in a loop. Similar stress testing had revealed the bug originally.
Awesome, please submit this formally. The copy you sent lacked a commit
message and signoff.
next prev parent reply other threads:[~2010-07-17 23:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 9:00 [PATCH 2.6.35-rc1] net: vmxnet3 fixes [0/5] Spare skb to avoid starvation Shreyas Bhatewara
2010-07-07 9:24 ` [PATCH 2.6.35-rc1] net: vmxnet3 fixes [2/5] Interrupt control bitmap Shreyas Bhatewara
2010-07-14 0:48 ` [PATCH 2.6.35-rc1] net-next: " Shreyas Bhatewara
2010-07-14 21:04 ` David Miller
2010-07-16 1:20 ` Shreyas Bhatewara
2010-07-16 5:19 ` David Miller
2010-07-07 9:28 ` [PATCH 2.6.35-rc1] net: vmxnet3 fixes [3/5] Initialize link state at probe time Shreyas Bhatewara
2010-07-07 9:31 ` [PATCH 2.6.35-rc1] net: vmxnet3 fixes [4/5] Do not reset when the device is not opened Shreyas Bhatewara
2010-07-14 0:49 ` [PATCH 2.6.35-rc1] net-next: " Shreyas Bhatewara
2010-07-14 21:07 ` David Miller
2010-07-16 1:20 ` Shreyas Bhatewara
2010-07-16 1:32 ` David Miller
2010-07-16 8:17 ` Shreyas Bhatewara
2010-07-17 23:35 ` David Miller [this message]
2010-07-19 17:02 ` Shreyas Bhatewara
2010-07-19 20:16 ` David Miller
2010-07-07 9:34 ` [PATCH 2.6.35-rc1] net: vmxnet3 fixes [5/5] Respect the interrupt type in VM configuration Shreyas Bhatewara
2010-07-14 0:51 ` [PATCH 2.6.35-rc1] net-next: " Shreyas Bhatewara
2010-07-14 21:11 ` David Miller
2010-07-16 1:21 ` Shreyas Bhatewara
2010-07-16 1:28 ` [PATCH 2.6.35-rc1] net-next: fix LRO feature update in vmxnet3 Shreyas Bhatewara
2010-07-16 5:17 ` David Miller
2010-07-19 20:16 ` [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [5/5] Respect the interrupt type in VM configuration David Miller
2010-07-14 0:48 ` [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [3/5] Initialize link state at probe time Shreyas Bhatewara
2010-07-14 21:10 ` David Miller
2010-07-16 1:20 ` Shreyas Bhatewara
2010-07-16 5:44 ` David Miller
2010-07-16 7:51 ` Shreyas Bhatewara
2010-07-18 21:49 ` David Miller
2010-07-07 21:40 ` [PATCH 2.6.35-rc1] net: vmxnet3 fixes [0/5] Spare skb to avoid starvation David Miller
2010-07-07 22:19 ` Shreyas Bhatewara
2010-07-07 22:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100717.163538.137865264.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthieu@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=ronghua@vmware.com \
--cc=sbhatewara@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®