mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.hengli.com.au>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Dan Kruchinin <dkruchinin@acm.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] padata: cpumasks
Date: Mon, 19 Jul 2010 15:32:55 +0800	[thread overview]
Message-ID: <20100719073255.GA20403@gondor.apana.org.au> (raw)
In-Reply-To: <20100719064050.GA11081@secunet.com>

On Mon, Jul 19, 2010 at 08:40:50AM +0200, Steffen Klassert wrote:
> On Mon, Jul 19, 2010 at 02:04:26PM +0800, Herbert Xu wrote:
> > 
> > All applied.  Thanks!
> 
> Hm, I was just about to write some comments on these patches,
> they still have some issues. For example, handling empty cpumasks
> is broken again (NULL pointer dereference in padata_replace).
> The cpu_index is zero for all cpus now, so can we leak objects
> on cpu hotplug etc. Also I'm not that happy with some of the
> API changes. I'll try to fix this up with some patches.

OK I'll take your fixes on top when you're ready.

Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2010-07-19  7:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14 10:29 Dan Kruchinin
2010-07-19  6:04 ` Herbert Xu
2010-07-19  6:40   ` Steffen Klassert
2010-07-19  7:32     ` Herbert Xu [this message]
2010-07-20  6:47       ` [PATCH 0/4] padata/pcrypt: fixes Steffen Klassert
2010-07-20  6:48         ` [PATCH 1/4] padata: Fix cpu index counting Steffen Klassert
2010-07-20  6:49         ` [PATCH 2/4] padata: Allocate cpumask dependend recources in any case Steffen Klassert
2010-07-20  6:51         ` [PATCH 3/4] padata: Check for valid cpumasks Steffen Klassert
2010-07-20  6:52         ` [PATCH 4/4] crypto: pcrypt - Dont calulate a callback cpu on empty callback cpumask Steffen Klassert
2010-07-26  6:16         ` [PATCH 0/4] padata/pcrypt: fixes Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100719073255.GA20403@gondor.apana.org.au \
    --to=herbert@gondor.hengli.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=dkruchinin@acm.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®