From: Jonathan Corbet <corbet@lwn.net>
To: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Tejun Heo <tj@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
vamos-dev@i4.informatik.uni-erlangen.de
Subject: Re: [PATCH 4/4] drivers/media/video: Remove dead CONFIG_OLPC_X0_1
Date: Mon, 19 Jul 2010 16:39:30 -0600 [thread overview]
Message-ID: <20100719163930.6c3333a7@bike.lwn.net> (raw)
In-Reply-To: <966ac7deeee8b102b9b8d829ca14e177f9368f21.1279111369.git.qy03fugy@stud.informatik.uni-erlangen.de>
On Wed, 14 Jul 2010 15:21:48 +0200
Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de> wrote:
> CONFIG_OLPC_X0_1 doesn't exist in Kconfig and is never defined anywhere
> else, therefore removing all references for it from the source code.
That symbol is, needless to say, an OLPC thing; it's in their
repository. I do think they plan to upstream all of that at some
point, but I think they're a little busy at the moment.
Deleting this code will increase the delta between the OLPC and
mainline trees. My preference would be for that not to happen. If it
does, though, life will obviously go on, and this code can be restored
when the rest is upstreamed. If you must do that, though, could I ask
that you preserve the CONFIG_OLPC_XO_1 version of the code, which is
the version which has traditionally been in the mainline?
jon
prev parent reply other threads:[~2010-07-19 22:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 13:21 [PATCH 0/4] Removing dead code Christian Dietrich
2010-07-14 13:21 ` [PATCH 1/4] drivers/media/dvb: Remove dead Configs Christian Dietrich
2010-07-14 13:21 ` [PATCH 2/4] drivers/media/dvb: Remove undead configs Christian Dietrich
2010-07-14 13:21 ` [PATCH 3/4] drivers/media/video: Remove dead CONFIG_FB_OMAP2_FORCE_AUTO_UPDATE Christian Dietrich
2010-07-14 13:21 ` [PATCH 4/4] drivers/media/video: Remove dead CONFIG_OLPC_X0_1 Christian Dietrich
2010-07-19 22:39 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719163930.6c3333a7@bike.lwn.net \
--to=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=qy03fugy@stud.informatik.uni-erlangen.de \
--cc=tj@kernel.org \
--cc=vamos-dev@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®