From: "Michał Górny" <gentoo@mgorny.alt.pl>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] KERNEL BUILD: Make the setlocalversion script POSIX-compliant.
Date: Tue, 20 Jul 2010 23:16:55 +0200 [thread overview]
Message-ID: <20100720231655.2226a38b@pomiocik.lan> (raw)
In-Reply-To: <4C45ABFD.8060308@suse.cz>
On Tue, 20 Jul 2010 16:00:29 +0200
Michal Marek <mmarek@suse.cz> wrote:
> > There is one 'bashism' left which I wasn't able to fix -- the use of
> > 'test -ef'. I'm not aware of any POSIX equivalent of that.
>
> Me neither, POSIX does not know stat(1) AFAICS. Does it matter in real
> life? Is there a distro that installs posh or a similarly strict shell
> as /bin/sh? It seems to work with dash after your changes.
I am not aware of any, and it does work with dash indeed. That's why I
have submitted the patch. I left that notice mostly because the actual
description suggested the script becomes 'POSIX-compliant'.
The second reason for that notice is that someone might want to fix
that sometime. But I guess the best way would be through complete
change of the check logic.
--
Best regards,
Michał Górny
<http://mgorny.alt.pl>
<xmpp:mgorny@jabber.ru>
prev parent reply other threads:[~2010-07-20 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 8:26 Michał Górny
2010-07-20 14:00 ` Michal Marek
2010-07-20 21:16 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720231655.2226a38b@pomiocik.lan \
--to=gentoo@mgorny.alt.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®