From: Florian Mickler <florian@mickler.org>
To: florian@mickler.org
Cc: linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
Venkatesh Pallipadi <venki@google.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix warning: us_to_pm_timer_ticks defined but not used
Date: Sat, 24 Jul 2010 10:57:17 +0200 [thread overview]
Message-ID: <20100724105717.430d0ae6@schatten.dmk.lab> (raw)
In-Reply-To: <1279900743-4733-1-git-send-email-florian@mickler.org>
On Fri, 23 Jul 2010 17:59:02 +0200
florian@mickler.org wrote:
> Move it under the same ifdef as its sole caller is.
>
> Signed-off-by: Florian Mickler <florian@mickler.org>
> ---
> drivers/acpi/processor_idle.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index b1b3856..8525070 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -80,10 +80,6 @@ module_param(nocst, uint, 0000);
> static unsigned int latency_factor __read_mostly = 2;
> module_param(latency_factor, uint, 0644);
>
> -static u64 us_to_pm_timer_ticks(s64 t)
> -{
> - return div64_u64(t * PM_TIMER_FREQUENCY, 1000000);
> -}
> /*
> * IBM ThinkPad R40e crashes mysteriously when going into C2 or C3.
> * For now disable this. Probably a bug somewhere else.
> @@ -685,6 +681,12 @@ static int acpi_processor_get_power_info(struct acpi_processor *pr)
> }
>
> #ifdef CONFIG_ACPI_PROCFS
> +
> +static u64 us_to_pm_timer_ticks(s64 t)
> +{
> + return div64_u64(t * PM_TIMER_FREQUENCY, 1000000);
> +}
> +
> static int acpi_processor_power_seq_show(struct seq_file *seq, void *offset)
> {
> struct acpi_processor *pr = seq->private;
Ah, I just saw the Patch from KOSAKI Motohiro ([patch 1/2] acpi: fix
unused function warning) to the same effect.
I should have checked the mailinglist before sending this :)
Sorry for the noise,
Flo
prev parent reply other threads:[~2010-07-24 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 15:59 florian
2010-07-24 8:57 ` Florian Mickler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100724105717.430d0ae6@schatten.dmk.lab \
--to=florian@mickler.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome