From: Alexander Shishkin <virtuoso@slind.org>
To: Hari Kanigeri <hari.kanigeri@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Richard Woodruff <r-woodruff2@ti.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Paul Walmsley <paul@pwsan.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] save and restore etm state across core OFF modes
Date: Sun, 25 Jul 2010 22:38:51 +0300 [thread overview]
Message-ID: <20100725193851.GA14399@shisha.kicks-ass.net> (raw)
In-Reply-To: <AANLkTinmSJ6dtgqmyuk9CArniPEvEp7TrXauvGxLxv7x@mail.gmail.com>
On Sun, Jul 25, 2010 at 12:34:22 -0600, Hari Kanigeri wrote:
> > +config ENABLE_OFF_MODE_JTAG_ETM_DEBUG
> > + bool "Enable hardware emulation context save and restore"
> > + depends on ARCH_OMAP3
>
> -- Shouldn't this be depends on OMAP3_EMU instead ?
Not really. OMAP3_EMU will enable ETM/ETB drivers within omap, but this
particular patch is also needed if you're using an external hardware
debugger to debug code across OFF modes.
> > + default y
>
> -- As this is debug option, can you keep this "n" by default ?
This option allows for enabling certain debugging functionality in runtime
(via a sysfs file), which is turned off by default. It is debatable whether
this option should default to 'y' or 'n', seeing as it doesn't add much
overhead to the normal usecase.
> > + help
> > + This option enables JTAG & ETM debugging across power states.
> > + With out this option emulation features are reset across OFF
> > + mode state changes.
But I see that the wording is misleading and unclear, so I'll try to come
up with something more descriptive.
Regards,
--
Alex
next prev parent reply other threads:[~2010-07-25 19:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <13B9B4C6EF24D648824FF11BE896716203BADA0745@dlee02.ent.ti.com>
2010-07-25 17:05 ` [PATCH 1/7] coresight: move struct tracectx inside etm driver Alexander Shishkin
2010-07-25 17:05 ` [PATCH 2/7] coresight: add ETM management registers Alexander Shishkin
2010-07-25 17:05 ` [PATCH 3/7] coresight: cosmetic fixes Alexander Shishkin
2010-07-25 17:05 ` [PATCH 4/7] etm: do a dummy read from OSSRR during initialization Alexander Shishkin
2010-07-25 17:05 ` [PATCH 5/7] omap3: move EMU peripheral addresses to a platform header Alexander Shishkin
2010-07-26 7:03 ` Shilimkar, Santosh
2010-07-25 17:05 ` [PATCH 6/7] save and restore etm state across core OFF modes Alexander Shishkin
2010-07-25 18:34 ` Hari Kanigeri
2010-07-25 19:38 ` Alexander Shishkin [this message]
2010-07-25 21:04 ` [PATCH] omap3: make coresight register save across OFF modes a sysfs option Alexander Shishkin
2010-07-25 21:14 ` Alexander Shishkin
2010-07-26 6:58 ` Shilimkar, Santosh
2010-07-26 7:32 ` Alexander Shishkin
2010-07-26 8:31 ` Shilimkar, Santosh
2010-07-26 9:04 ` Alexander Shishkin
2010-07-25 21:15 ` [PATCH] save and restore etm state across core OFF modes Alexander Shishkin
2010-07-30 12:16 ` [PATCH 6/7] " Alexander Shishkin
2010-07-25 17:05 ` [PATCH 7/7] omap3: make coresight register save across OFF modes a sysfs option Alexander Shishkin
2010-08-06 12:37 ` Alexander Shishkin
2010-08-06 12:47 ` Tony Lindgren
2010-09-04 8:57 ` Cousson, Benoit
2010-09-23 17:52 ` Tony Lindgren
2010-08-26 9:14 ` [PATCH 1/3] omap3: move EMU peripheral addresses to a platform header Alexander Shishkin
2010-08-26 9:14 ` [PATCH 2/3] save and restore etm state across core OFF modes Alexander Shishkin
2010-08-26 9:14 ` [PATCH 3/3] omap3: make coresight register save across OFF modes a sysfs option Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100725193851.GA14399@shisha.kicks-ass.net \
--to=virtuoso@slind.org \
--cc=hari.kanigeri@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=r-woodruff2@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®