From: David Miller <davem@davemloft.net>
To: grant.likely@secretlab.ca
Cc: sam@ravnborg.org, sfr@canb.auug.org.au, monstr@monstr.eu,
microblaze-uclinux@itee.uq.edu.au,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
benh@kernel.crashing.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()
Date: Mon, 26 Jul 2010 15:48:54 -0700 (PDT) [thread overview]
Message-ID: <20100726.154854.35052662.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTikcV3jJUm_My-oK-drudSDz3M2iH1cWhxdt+W1s@mail.gmail.com>
From: Grant Likely <grant.likely@secretlab.ca>
Date: Mon, 26 Jul 2010 16:42:20 -0600
> It protects against some later include file doing a #define
> of_node_to_nid and thus resulting in an inconsistent definition. If
> some code tries to do this then the preprocessor will complain. This
> is the pattern that Stephen suggested.
Also, it would be nice to unravel the "0" vs. "-1" default
inconsistency.
next prev parent reply other threads:[~2010-07-26 22:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 22:04 Grant Likely
2010-07-26 22:05 ` Grant Likely
2010-07-26 22:26 ` Sam Ravnborg
2010-07-26 22:42 ` Grant Likely
2010-07-26 22:48 ` David Miller [this message]
2010-07-26 22:51 ` Grant Likely
2010-07-27 1:38 ` David Miller
2010-07-27 1:57 ` Grant Likely
2010-07-27 13:34 ` Arnd Bergmann
2010-07-27 16:52 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726.154854.35052662.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome