From: Sam Ravnborg <sam@ravnborg.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Michal Marek <mmarek@suse.cz>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 3/3] kbuild: allow user to assign LDFLAGS_MODULE
Date: Mon, 26 Jul 2010 23:48:36 +0200 [thread overview]
Message-ID: <20100726214836.GA22433@merkur.ravnborg.org> (raw)
In-Reply-To: <AANLkTimrZwE+_awxxoQtdkeS7OVY+jDMawyfkYUas58G@mail.gmail.com>
On Mon, Jul 26, 2010 at 04:54:05PM -0400, Mike Frysinger wrote:
> On Mon, Jul 26, 2010 at 16:44, Sam Ravnborg wrote:
> > From ce765a28adeb8878413a49ce62f442022d6a5b6a Mon Sep 17 00:00:00 2001
> > From: Sam Ravnborg <sam@ravnborg.org>
> > Date: Mon, 26 Jul 2010 22:20:12 +0200
> > Subject: [PATCH 3/3] kbuild: allow user to assign LDFLAGS_MODULE
> >
> > Do not use LDFLAGS_MODULE in the top-level Makefile.
> > So if user assign a value to LDFALGS_MODULE the
> > original value is not lost.
> >
> > Use a kbuild internal variable that archs can use,
> > and update all archs that used LDFALGS_MODULE.
>
> assuming end behavior is the same, the Blackfin part is:
> Acked-by: Mike Frysinger <vapier@gentoo.org>
It is :-)
>
> also, could you say the same thing for CFLAGS_MODULE ?
Good point. Need to do the same here.
I also realised I need to update Documentation/kbuild/makefiles.txt
Michal - I will send an updated serie tomorrow.
Sam
next prev parent reply other threads:[~2010-07-26 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 20:38 [PATCH 0/3] update of various kbuild flags to allow user settings Sam Ravnborg
2010-07-26 20:42 ` [PATCH 1/3] kbuild: allow user to assign {A,C}FLAGS_MODULE Sam Ravnborg
2010-07-26 20:43 ` [PATCH 2/3] frv: remove useless ARCHMODFLAGS assignment Sam Ravnborg
2010-07-26 20:44 ` [PATCH 3/3] kbuild: allow user to assign LDFLAGS_MODULE Sam Ravnborg
2010-07-26 20:54 ` Mike Frysinger
2010-07-26 21:48 ` Sam Ravnborg [this message]
2010-07-27 9:00 ` [PATCH 2/3] frv: remove useless ARCHMODFLAGS assignment David Howells
2010-07-27 9:13 ` Sam Ravnborg
2010-07-27 9:15 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726214836.GA22433@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=tony.luck@intel.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®