From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Israel Schlesinger <israels@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, apw@canonical.com,
akpm@linux-foundation.org, joe@perches.com
Subject: Re: [PATCH v2] checkpatch: Add warnings for use of mdelay()
Date: Wed, 28 Jul 2010 11:16:03 +0800 [thread overview]
Message-ID: <20100728031603.GB5161@cr0.nay.redhat.com> (raw)
In-Reply-To: <4C4F16EE.9010008@codeaurora.org>
On Tue, Jul 27, 2010 at 10:27:10AM -0700, Israel Schlesinger wrote:
>mdelay is a busy-wait loop which is wasteful. If at all possible,
>callers should use msleep instead of mdelay.
>
>The only time mdelay is really appropriate is in atomic context,
>however, delays of 1ms+ in atomic context are rather expensive, so
>a warning for this case is probably appropriate as well to encourage
>people to move such expensive delays outside of atomic context
>
Then udelay() is also preferred...
prev parent reply other threads:[~2010-07-28 3:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 17:27 Israel Schlesinger
2010-07-28 3:16 ` Américo Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100728031603.GB5161@cr0.nay.redhat.com \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=israels@codeaurora.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®