From: Sam Ravnborg <sam@ravnborg.org>
To: Michal Marek <mmarek@suse.cz>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Roman Zippel <zippel@linux-m68k.org>,
Uwe Kleine-Koig <u.kleine-koenig@pengutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC PATCH] kconfig: use long options in conf
Date: Thu, 29 Jul 2010 11:39:46 +0200 [thread overview]
Message-ID: <20100729093946.GA6725@merkur.ravnborg.org> (raw)
In-Reply-To: <4C51473A.4000605@suse.cz>
On Thu, Jul 29, 2010 at 11:17:46AM +0200, Michal Marek wrote:
> On 28.7.2010 22:36, Sam Ravnborg wrote:
> > Hi Michal.
> >
> > I cooked up the following to introduce long options in conf.
> > But in the process I dropped the short options. Is this OK?
>
> Nice! I would probably name the option and the enum value for randconfig
> simply --randconfig to not introduce new names (the scripts/kconfig/conf
> call is displayed to the user).
I had in mind to deprecate randconfig in favour of allrandconfig
to get more consitency in the names.
But I failed to document this in the changelog.
I can submit the following as a real patch if you agree.
Sam
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 1290ac3..9670323 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -101,12 +101,12 @@ update-po-config: $(obj)/kxgettext $(obj)/gconf.glade.h
$(Q)rm -f arch/um/Kconfig.arch
$(Q)rm -f $(obj)/config.pot
-PHONY += randconfig allyesconfig allnoconfig allmodconfig defconfig
+PHONY += allnoconfig allyesconfig allmodconfig allrandconfig randconfig defconfig
-randconfig: $(obj)/conf
- $< --allrandconfig $(Kconfig)
+# Support deprecated randconfig target
+randconfig: allrandconfig
-allnoconfig allyesconfig allmodconfig: $(obj)/conf
+allnoconfig allyesconfig allmodconfig allrandconfig: $(obj)/conf
$< --$@ $(Kconfig)
defconfig: $(obj)/conf
@@ -131,7 +131,7 @@ help:
@echo ' localmodconfig - Update current config disabling modules not loaded'
@echo ' localyesconfig - Update current config converting local mods to core'
@echo ' silentoldconfig - Same as oldconfig, but quietly, additionally update deps'
- @echo ' randconfig - New config with random answer to all options'
+ @echo ' allrandconfig - New config with random answer to all options'
@echo ' defconfig - New config with default answer to all options'
@echo ' allmodconfig - New config selecting modules when possible'
@echo ' allyesconfig - New config where all options are accepted with yes'
next prev parent reply other threads:[~2010-07-29 9:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 21:38 [RFC] kconfig: introduce alldefconfig + savedefconfig Sam Ravnborg
2010-07-25 21:38 ` [PATCH 1/4] kconfig: save location of config symbols Sam Ravnborg
2010-07-25 21:39 ` [PATCH 2/4] kconfig: print more info when we see a recursive dependency Sam Ravnborg
2010-07-25 21:39 ` [PATCH 3/4] kconfig: add alldefconfig Sam Ravnborg
2010-07-25 21:40 ` [PATCH 4/4] kconfig: add savedefconfig Sam Ravnborg
2010-07-27 15:42 ` Michal Marek
2010-07-27 16:50 ` Sam Ravnborg
2010-07-28 20:36 ` [RFC PATCH] kconfig: use long options in conf Sam Ravnborg
2010-07-29 8:13 ` Sam Ravnborg
2010-07-29 8:15 ` [PATCH 1/2] kconfig: rename loose_nonint_oldconfig => oldnoconfig Sam Ravnborg
2010-07-29 8:16 ` [PATCH 2/2] kconfig: change nonint_oldconfig to listnewconfig Sam Ravnborg
2010-07-29 9:23 ` [RFC PATCH] kconfig: use long options in conf Michal Marek
2010-07-29 14:47 ` Aristeu Rozanski
2010-07-29 15:04 ` Michal Marek
2010-07-29 15:16 ` Aristeu Rozanski
2010-07-29 19:34 ` Sam Ravnborg
2010-07-29 19:50 ` Aristeu Rozanski
2010-07-29 23:04 ` Sam Ravnborg
2010-07-30 14:53 ` Aristeu Rozanski
2010-07-29 9:17 ` Michal Marek
2010-07-29 9:39 ` Sam Ravnborg [this message]
2010-07-29 10:08 ` Michal Marek
2010-07-29 14:30 ` Randy Dunlap
2010-07-29 19:29 ` Sam Ravnborg
2010-07-25 22:20 ` [RFC] kconfig: introduce alldefconfig + savedefconfig Sam Ravnborg
2010-07-28 6:47 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100729093946.GA6725@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®