From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
"Michael H. Warfield" <mhw@wittsend.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Rakib Mullick <rakib.mullick@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ben Hutchings <ben@decadent.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: ip2: check put_user() result
Date: Thu, 29 Jul 2010 17:13:00 +0100 [thread overview]
Message-ID: <20100729171300.5ecc0bc2@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1280418938-5833-1-git-send-email-segooon@gmail.com>
O> - return dumpcount;
> + return rc ? -EFAULT : dumpcount;
This is actually at least as wrong as before.
The standards say that if you successfully return some data you should
report the bytes returned. Normally it doesn't matter much because the
data has not been 'lost' when it gets called again.
If you actually remove the data from the queue it ought to be getting
reported with a suitable length.
Alan
prev parent reply other threads:[~2010-07-29 16:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 15:55 Kulikov Vasiliy
2010-07-29 16:13 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100729171300.5ecc0bc2@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhw@wittsend.com \
--cc=rakib.mullick@gmail.com \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®