From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-pci@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: Do not run NVidia quirks related to MSI with MSI disabled
Date: Fri, 30 Jul 2010 09:47:55 -0700 [thread overview]
Message-ID: <20100730094755.7f53b7d8@virtuousgeek.org> (raw)
In-Reply-To: <201007232219.55331.rjw@sisk.pl>
On Fri, 23 Jul 2010 22:19:55 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> There is no reason to run NVidia-specific quirks related to HT MSI
> mappings with MSI disabled via pci=nomsi, so make
> __nv_msi_ht_cap_quirk() return immediately in that case.
>
> This allows at least one machine to boot 100% of the time with
> pci=nomsi (it still doesn't boot reliably without that).
>
> Addresses https://bugzilla.kernel.org/show_bug.cgi?id=16443 .
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/pci/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux-2.6/drivers/pci/quirks.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/quirks.c
> +++ linux-2.6/drivers/pci/quirks.c
> @@ -2390,6 +2390,9 @@ static void __devinit __nv_msi_ht_cap_qu
> int pos;
> int found;
>
> + if (!pci_msi_enabled())
> + return;
> +
> /* check if there is HT MSI cap or enabled on this device */
> found = ht_check_msi_mapping(dev);
applied to linux-next with a cc: stable. Thanks.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-07-30 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 20:19 Rafael J. Wysocki
2010-07-30 16:47 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730094755.7f53b7d8@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®