From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: Kernel Janitors <kernel-janitors@vger.kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 17/19] drivers/pci: use for_each_pci_dev()
Date: Fri, 30 Jul 2010 09:48:33 -0700 [thread overview]
Message-ID: <20100730094833.47a3e638@virtuousgeek.org> (raw)
In-Reply-To: <1278173080-11983-1-git-send-email-segooon@gmail.com>
On Sat, 3 Jul 2010 20:04:39 +0400
Kulikov Vasiliy <segooon@gmail.com> wrote:
> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/pci/setup-irq.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
> index aa795fd..eec9738 100644
> --- a/drivers/pci/setup-irq.c
> +++ b/drivers/pci/setup-irq.c
> @@ -59,7 +59,6 @@ pci_fixup_irqs(u8 (*swizzle)(struct pci_dev *, u8 *),
> int (*map_irq)(struct pci_dev *, u8, u8))
> {
> struct pci_dev *dev = NULL;
> - while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> + for_each_pci_dev(dev)
> pdev_fixup_irq(dev, swizzle, map_irq);
> - }
> }
Applied all of these to my linux-next branch. I squashed all the PCI
ones into a single commit, keeping only the x86 one separate.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-07-30 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 16:04 Kulikov Vasiliy
2010-07-30 16:48 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730094833.47a3e638@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome