From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, Nicolas Pitre <nico@marvell.com>,
linux-kernel@vger.kernel.org, Julia Lawall <julia@diku.dk>,
Tejun Heo <tj@kernel.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] MTD: pxa2xx: move pxa2xx_flash_probe to .devinit.text
Date: Fri, 30 Jul 2010 20:51:06 +0200 [thread overview]
Message-ID: <20100730185106.GA25446@pengutronix.de> (raw)
In-Reply-To: <4C52F6C1.5090207@mvista.com>
On Fri, Jul 30, 2010 at 07:58:57PM +0400, Sergei Shtylyov wrote:
> Uwe Kleine-König wrote:
>
>> This fixes the following warning by modpost:
>
>> WARNING: vmlinux.o(.data+0x15018): Section mismatch in reference from the variable pxa2xx_flash_driver to the function .init.text:pxa2xx_flash_probe()
>> The variable pxa2xx_flash_driver references
>> the function __init pxa2xx_flash_probe()
>> If the reference is valid then annotate the
>> variable with __init* or __refdata (see linux/init.h) or name the variable:
>> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
>> I choosed to do this instead of using platform_driver_probe as the remove
>
> s/choosed/chose/
oh right, thanks.
>> function uses __devexit.
>
> Perhaps remove() method should have been fixed instead -- I doubt that
> this is a hotplug device.
Actually I don't care much.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-07-30 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 15:42 Uwe Kleine-König
2010-07-30 15:58 ` Sergei Shtylyov
2010-07-30 18:51 ` Uwe Kleine-König [this message]
2010-07-30 19:02 ` [PATCH] trivial: fix typo "choosed" -> "chosen" Uwe Kleine-König
2010-08-04 13:08 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730185106.GA25446@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=dwmw2@infradead.org \
--cc=julia@diku.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nico@marvell.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sshtylyov@mvista.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome