From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756271Ab0GaTIP (ORCPT ); Sat, 31 Jul 2010 15:08:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11085 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754944Ab0GaTIM (ORCPT ); Sat, 31 Jul 2010 15:08:12 -0400 Date: Sat, 31 Jul 2010 20:07:57 +0100 From: Alasdair G Kergon To: "Justin P. Mattock" Cc: dm-devel@redhat.com, neilb@suse.de, agk@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]md:dm.c Fix warning: statement with no effect Message-ID: <20100731190757.GC9734@agk-dp.fab.redhat.com> Mail-Followup-To: "Justin P. Mattock" , dm-devel@redhat.com, neilb@suse.de, agk@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org References: <1278984400-8837-1-git-send-email-justinmattock@gmail.com> <4C5473E0.308@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C5473E0.308@gmail.com> Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 31, 2010 at 12:05:04PM -0700, Justin P. Mattock wrote: > haven't heard any feedback on this any ideas? >> Ive noticed that having CONFIG_BLK_DEV_INTEGRITY=n I get warning messages generated by GCC(below) >> CC drivers/md/dm.o >> drivers/md/dm.c: In function 'split_bvec': >> drivers/md/dm.c:1117:3: warning: statement with no effect >> drivers/md/dm.c: In function 'clone_bio': >> drivers/md/dm.c:1145:3: warning: statement with no effect I'd suggest hiding it inside the .h files and not trying to scatter #ifdefs throughout the code. Alasdair