From: Wim Van Sebroeck <wim@iguana.be>
To: David Daney <ddaney@caviumnetworks.com>, ralf@linux-mips.org
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>,
Marc Zyngier <maz@misterjones.org>,
Thierry Reding <thierry.reding@avionic-design.de>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] watchdog: Add watchdog driver for OCTEON SOCs (v2).
Date: Mon, 2 Aug 2010 14:37:55 +0200 [thread overview]
Message-ID: <20100802123755.GV30740@infomag.iguana.be> (raw)
In-Reply-To: <1279991765-23962-1-git-send-email-ddaney@caviumnetworks.com>
Hi David, Ralf,
> The OCTEON is a MIPS64 based SOC family with an on chip watchdog unit.
>
> The driver is split into two source files one for the C code and one
> for assembly. Assembly is needed to handle the NMI and then print the
> machine state before the reboot is triggered.
>
> v2: Stylistic changes suggested by Sam Ravnborg.
This v2 looks good. only small remark is:
> +static struct notifier_block octeon_wdt_cpu_notifier = {
> + .notifier_call = octeon_wdt_cpu_callback
> +};
Add a comma after octeon_wdt_cpu_callback.
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Marc Zyngier <maz@misterjones.org>
> Cc: Thierry Reding <thierry.reding@avionic-design.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
Kind regards,
Wim.
next prev parent reply other threads:[~2010-08-02 12:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-24 1:41 [PATCH 0/7] Watchdog driver for Octeon SOCs David Daney
2010-07-24 1:41 ` [PATCH 1/7] MIPS: Add drotr32 and uasm_i_drotr_safe to uasm David Daney
2010-07-24 2:54 ` Ralf Baechle
2010-07-24 1:41 ` [PATCH 2/7] MIPS: Add BBIT0 and BBIT1 instructions " David Daney
2010-07-24 2:55 ` Ralf Baechle
2010-07-24 1:41 ` [PATCH 3/7] MIPS: Add option to export uasm API David Daney
2010-07-24 2:55 ` Ralf Baechle
2010-07-24 1:41 ` [PATCH 4/7] MIPS: Octeon: Export prom_putchar() David Daney
2010-07-24 2:55 ` Ralf Baechle
2010-07-24 1:41 ` [PATCH 5/7] MIPS: Export __cpu_number_map and __cpu_logical_map David Daney
2010-07-24 2:55 ` Ralf Baechle
2010-07-24 1:41 ` [PATCH 6/7] MIPS: Define ST0_NMI in asm/mipsregs.h David Daney
2010-07-24 2:55 ` Ralf Baechle
2010-07-24 1:41 ` [PATCH 7/7] watchdog: Add watchdog driver for OCTEON SOCs David Daney
2010-07-24 3:07 ` Ralf Baechle
2010-07-29 18:08 ` Wim Van Sebroeck
2010-07-24 3:58 ` Sam Ravnborg
2010-07-24 17:16 ` [PATCH] watchdog: Add watchdog driver for OCTEON SOCs (v2) David Daney
2010-08-02 12:37 ` Wim Van Sebroeck [this message]
2010-08-02 12:57 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802123755.GV30740@infomag.iguana.be \
--to=wim@iguana.be \
--cc=akpm@linux-foundation.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=maz@misterjones.org \
--cc=ralf@linux-mips.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sam@ravnborg.org \
--cc=thierry.reding@avionic-design.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®