From: Sam Ravnborg <sam@ravnborg.org>
To: Michal Marek <mmarek@suse.cz>
Cc: Arve Hj?nnev?g <arve@android.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
JBeulich@novell.com, aris@redhat.com, catalin.marinas@arm.com,
jacmet@sunsite.dk, justinmattock@gmail.com, lizf@cn.fujitsu.com,
ulfalizer.lkml@gmail.com, zippel@linux-m68k.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT] kbuild: kconfig changes
Date: Tue, 10 Aug 2010 16:25:20 +0200 [thread overview]
Message-ID: <20100810142520.GA15073@merkur.ravnborg.org> (raw)
In-Reply-To: <4C615C84.6060300@suse.cz>
> >
> > The reason why your patch cured it was that we then no
> > longer triggered the bug (at least I guess so I did not look to close).
> >
> > I will look into this as time permits. I assume the fix is simple
> > when I find the reason.
>
> I'm looking into it now, but understanding the kconfig internals is not
> easy...
Nope...
What I have understood so far...
If we have a choice then the choice is represented by a symbol.
symbol->def[S_DEF_USER] is set to the selected symbol.
If we read all the choice values then we set:
symbol->flags |= SYMBOL_DEF_USER
If we have a choice where we do not have all choice_values
which is the case with the minimal defconfig then the
missing choice_value results in that SYMBOL_DEF_USER
is not set.
[See confdata:conf_read after the sym_ok label]
Later in symbol.c:sym_calc_value the visibility
is set to mod if we do not have all values.
And therefore the coice value is set to m not y.
I will look a bit more at it tonight.
Sam
next prev parent reply other threads:[~2010-08-10 14:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 12:51 Michal Marek
2010-08-05 23:33 ` Linus Torvalds
2010-08-06 1:27 ` Justin P. Mattock
2010-08-06 2:08 ` Linus Torvalds
2010-08-06 2:54 ` Justin P. Mattock
2010-08-06 5:13 ` [PATCH] kconfig: fix make oldconfig Sam Ravnborg
2010-08-06 6:02 ` Justin P. Mattock
2010-08-06 10:21 ` Michal Marek
2010-08-06 16:19 ` Linus Torvalds
2010-08-06 17:52 ` Sam Ravnborg
2010-08-06 18:09 ` Linus Torvalds
2010-08-06 19:52 ` Justin P. Mattock
2010-08-06 23:19 ` [GIT] kbuild: kconfig changes Arve Hjønnevåg
2010-08-07 4:01 ` Sam Ravnborg
2010-08-07 4:43 ` Arve Hjønnevåg
2010-08-08 15:57 ` Sam Ravnborg
2010-08-10 14:04 ` Michal Marek
2010-08-10 14:25 ` Sam Ravnborg [this message]
2010-08-11 19:51 ` Sam Ravnborg
2010-08-11 20:34 ` Sam Ravnborg
2010-08-11 23:39 ` Arve Hjønnevåg
2010-08-12 3:45 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810142520.GA15073@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=JBeulich@novell.com \
--cc=aris@redhat.com \
--cc=arve@android.com \
--cc=catalin.marinas@arm.com \
--cc=jacmet@sunsite.dk \
--cc=justinmattock@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mmarek@suse.cz \
--cc=torvalds@linux-foundation.org \
--cc=ulfalizer.lkml@gmail.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®