mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Ernst Schwab <eschwab@online.de>,
	spi-devel-general@lists.sourceforge.net,
	lkml <linux-kernel@vger.kernel.org>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
	Grant Likely <grant.likely@secretlab.ca>
Subject: spi.h: missing kernel-doc notation, please fix
Date: Sun, 15 Aug 2010 10:31:56 -0700	[thread overview]
Message-ID: <20100815103156.37ae14cd.rdunlap@xenotime.net> (raw)

Hi Ernst,

This patch in mainline:

commit cf32b71e981ca63e8f349d8585ca2a3583b556e0
Author: Ernst Schwab <eschwab@online.de>
Date:   Mon Jun 28 17:49:29 2010 -0700

    spi/mmc_spi: SPI bus locking API, using mutex

adds some struct fields but does not add kernel-doc notation for them.
Please add that missing struct documentation.

Warning(include/linux/spi/spi.h:304): No description found for parameter 'bus_lock_spinlock'
Warning(include/linux/spi/spi.h:304): No description found for parameter 'bus_lock_mutex'
Warning(include/linux/spi/spi.h:304): No description found for parameter 'bus_lock_flag'

thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

             reply	other threads:[~2010-08-15 17:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-15 17:31 Randy Dunlap [this message]
2010-08-16 13:10 ` Ernst Schwab
2010-08-16 15:36   ` Randy Dunlap
2010-08-16 21:09   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100815103156.37ae14cd.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=eschwab@online.de \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®