From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756119Ab0HPTYs (ORCPT ); Mon, 16 Aug 2010 15:24:48 -0400 Received: from h5.dl5rb.org.uk ([81.2.74.5]:55798 "EHLO h5.dl5rb.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756007Ab0HPTYq (ORCPT ); Mon, 16 Aug 2010 15:24:46 -0400 Date: Mon, 16 Aug 2010 20:23:50 +0100 From: Ralf Baechle To: Julia Lawall Cc: "David S. Miller" , linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 8/16] net/ax25: Use available error codes Message-ID: <20100816192350.GA10921@linux-mips.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2010 at 06:26:57PM +0200, Julia Lawall wrote: > From: Julia Lawall > > Error codes are stored in err, but the return value is always 0. Return > err instead. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @r@ > local idexpression x; > constant C; > @@ > > if (...) { ... > x = -C > ... when != x > ( > return <+...x...+>; > | > return NULL; > | > return; > | > * return ...; > ) > } > // > > Signed-off-by: Julia Lawall > > --- > This changes the semantics and has not been tested. It restores the semantics to what they should be and used to be. This probably happened during the introduction of proper refcounting and locking into the AX.25 stack. Looks fine to me. Acked-by: Ralf Baechle Ralf