From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756296Ab0HPTbu (ORCPT ); Mon, 16 Aug 2010 15:31:50 -0400 Received: from h5.dl5rb.org.uk ([81.2.74.5]:38677 "EHLO h5.dl5rb.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756249Ab0HPTbs (ORCPT ); Mon, 16 Aug 2010 15:31:48 -0400 Date: Mon, 16 Aug 2010 20:31:01 +0100 From: Ralf Baechle To: Julia Lawall Cc: Joerg Reuter , "David S. Miller" , linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 13/16] net/ax25: Use available error codes Message-ID: <20100816193100.GB10921@linux-mips.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2010 at 06:28:19PM +0200, Julia Lawall wrote: > Error codes are stored in err, but the return value is always 0. Return > err instead. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @r@ > local idexpression x; > constant C; > @@ > > if (...) { ... > x = -C > ... when != x > ( > return <+...x...+>; > | > return NULL; > | > return; > | > * return ...; > ) > } > // > > Signed-off-by: Julia Lawall > > --- > This changes the semantics of the function and has not been tested. It restores the semantics to what they should be and used to be. This probably happened during the introduction of proper refcounting and locking into the AX.25 stack. Looks fine to me. Acked-by: Ralf Baechle Ralf