From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dan Carpenter <error27@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] pata_winbond: fix module init
Date: Tue, 17 Aug 2010 11:07:33 +0100 [thread overview]
Message-ID: <20100817110733.1c57aedd@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20100817062830.GF645@bicker>
On Tue, 17 Aug 2010 08:29:40 +0200
Dan Carpenter <error27@gmail.com> wrote:
> On Mon, Aug 16, 2010 at 09:23:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
> >
> > Hi Dan,
> >
> > On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote:
> > > winbond_init_one() returns 0 on success and an error code on failure.
> > > In the original code, we always just released the regions and return
> > > -ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
> > > Winbond support".
> >
> > You might like to pick up
> >
> > http://patchwork.ozlabs.org/patch/39358/
> >
> > instead..
> >
>
> I don't have the hardware, but yes, probably it's better to replace this
> driver since it has never been able to load.
It was obsoleted into pata_legacy before it was ever finalised -
unfortunately I could then not get Jeff to delete it.
next prev parent reply other threads:[~2010-08-17 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 15:27 Dan Carpenter
2010-08-16 19:23 ` Bartlomiej Zolnierkiewicz
2010-08-17 6:29 ` Dan Carpenter
2010-08-17 10:07 ` Alan Cox [this message]
2010-08-17 17:39 ` Jeff Garzik
2010-08-17 21:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817110733.1c57aedd@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=error27@gmail.com \
--cc=jgarzik@pobox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®