mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: change a temporary variable name in ia32_signal.c
Date: Wed, 18 Aug 2010 13:44:37 +0800	[thread overview]
Message-ID: <20100818054437.GC5243@cr0.nay.redhat.com> (raw)
In-Reply-To: <1282108520-8723-1-git-send-email-namhyung@gmail.com>

On Wed, Aug 18, 2010 at 02:15:20PM +0900, Namhyung Kim wrote:
>This removes following sparse warnings:
>
> ia32_signal.c:240:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
> ia32_signal.c:241:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
> ia32_signal.c:242:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
> ia32_signal.c:243:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
> ia32_signal.c:249:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
> ia32_signal.c:250:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
>
>Signed-off-by: Namhyung Kim <namhyung@gmail.com>


Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>

Thanks.

>---
> arch/x86/ia32/ia32_signal.c |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c
>index 348928a..6db169d 100644
>--- a/arch/x86/ia32/ia32_signal.c
>+++ b/arch/x86/ia32/ia32_signal.c
>@@ -202,9 +202,9 @@ asmlinkage long sys32_sigaltstack(const stack_ia32_t __user *uss_ptr,
> }
> 
> #define GET_SEG(seg)		({			\
>-	unsigned short tmp;				\
>-	get_user_ex(tmp, &sc->seg);			\
>-	tmp;						\
>+	unsigned short __tmp;				\
>+	get_user_ex(__tmp, &sc->seg);			\
>+	__tmp;						\
> })
> 
> #define COPY_SEG_CPL3(seg)	do {			\
>-- 
>1.7.0.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

      reply	other threads:[~2010-08-18  5:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18  5:15 Namhyung Kim
2010-08-18  5:44 ` Américo Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100818054437.GC5243@cr0.nay.redhat.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®