From: H Hartley Sweeten <hartleys@visionengravers.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: <linux-input@vger.kernel.org>, <dmitry.torokhov@gmail.com>
Subject: [PATCH] iforce: simplify Kconfig depends
Date: Wed, 18 Aug 2010 10:06:26 -0700 [thread overview]
Message-ID: <201008181006.26891.hartleys@visionengravers.com> (raw)
The depends on for JOYSTICK_IFORCE is already handled in drivers/input/Kconfig and
drivers/input/joystick/Kconfig.
Remove the depends on JOYSTICK_IFORCE for the *_USB and *_232 connections
by wrapping them in an if/endif block. The second depends on check is still needed
to prevent the iforce driver from being built-in while the connection is a module.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Should the connection depends on be changed to a select similar to the other
joystick drivers?
diff --git a/drivers/input/joystick/iforce/Kconfig b/drivers/input/joystick/iforce/Kconfig
index 8fde22a..d5fa68d 100644
--- a/drivers/input/joystick/iforce/Kconfig
+++ b/drivers/input/joystick/iforce/Kconfig
@@ -3,7 +3,6 @@
#
config JOYSTICK_IFORCE
tristate "I-Force devices"
- depends on INPUT && INPUT_JOYSTICK
help
Say Y here if you have an I-Force joystick or steering wheel
@@ -12,16 +11,18 @@ config JOYSTICK_IFORCE
To compile this driver as a module, choose M here: the
module will be called iforce.
+if JOYSTICK_IFORCE
+
config JOYSTICK_IFORCE_USB
bool "I-Force USB joysticks and wheels"
- depends on JOYSTICK_IFORCE && (JOYSTICK_IFORCE=m || USB=y) && USB
+ depends on (JOYSTICK_IFORCE=m || USB=y) && USB
help
Say Y here if you have an I-Force joystick or steering wheel
connected to your USB port.
config JOYSTICK_IFORCE_232
bool "I-Force Serial joysticks and wheels"
- depends on JOYSTICK_IFORCE && (JOYSTICK_IFORCE=m || SERIO=y) && SERIO
+ depends on (JOYSTICK_IFORCE=m || SERIO=y) && SERIO
help
Say Y here if you have an I-Force joystick or steering wheel
connected to your serial (COM) port.
@@ -30,3 +31,4 @@ config JOYSTICK_IFORCE_232
<file:Documentation/input/joystick.txt>
and <file:Documentation/input/ff.txt>.
+endif
next reply other threads:[~2010-08-18 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 17:06 H Hartley Sweeten [this message]
2010-08-19 5:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008181006.26891.hartleys@visionengravers.com \
--to=hartleys@visionengravers.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®