Re: [PATCH] Fix the declaration of sys_execve() in asm-generic/syscalls.h

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 18 Aug 2010 18:55:33 +0100
David Howells <dhowells@redhat.com> wrote:

> Fix the declaration of sys_execve() in asm-generic/syscalls.h to have various
> consts applied to its pointers.
> 

crappy changelog :(

> ---
> 
>  include/asm-generic/syscalls.h |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/include/asm-generic/syscalls.h b/include/asm-generic/syscalls.h
> index df84e3b..d89dec8 100644
> --- a/include/asm-generic/syscalls.h
> +++ b/include/asm-generic/syscalls.h
> @@ -23,8 +23,10 @@ asmlinkage long sys_vfork(struct pt_regs *regs);
>  #endif
>  
>  #ifndef sys_execve
> -asmlinkage long sys_execve(char __user *filename, char __user * __user *argv,
> -			char __user * __user *envp, struct pt_regs *regs);
> +asmlinkage long sys_execve(const char __user *filename,
> +			   const char __user *const __user *argv,
> +			   const char __user *const __user *envp,
> +			   struct pt_regs *regs);
>  #endif
>  
>  #ifndef sys_mmap2

Is this recent breakage?

In what way does the problem exhibit itself?

If we know these things we can then work out if the patch is needed in
2.6.36 and -stable.