From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
"Guy, Wey-Yi W" <wey-yi.w.guy@intel.com>
Subject: Re: [PATCH] firmware_class: fix typo in error path
Date: Wed, 18 Aug 2010 22:26:56 -0700 [thread overview]
Message-ID: <20100819052655.GD5832@core.coreip.homeip.net> (raw)
In-Reply-To: <20100818154330.GA4000@kroah.com>
On Wed, Aug 18, 2010 at 08:43:30AM -0700, Greg KH wrote:
> On Wed, Aug 18, 2010 at 05:15:18PM +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > In the error path, _request_firmware sets
> > firmware_p to NULL rather than *firmware_p,
> > which leads to passing a freed firmware
> > struct to drivers when the firmware file
> > cannot be found. Fix this.
> >
> > Broken by commit f8a4bd3456b988fc73b2c.
>
> Nice catch, thanks. I'll queue it up.
>
Yep, looks good, thank you for fixing this,
--
Dmitry
prev parent reply other threads:[~2010-08-19 5:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 15:15 Johannes Berg
2010-08-18 15:43 ` Greg KH
2010-08-19 5:26 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819052655.GD5832@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome