From: Andrew Morton <akpm@linux-foundation.org>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] timer: initialize the field slack of timer_list
Date: Thu, 19 Aug 2010 16:55:22 -0700 [thread overview]
Message-ID: <20100819165522.7e608703.akpm@linux-foundation.org> (raw)
In-Reply-To: <1282027064-7481-1-git-send-email-xiaosuo@gmail.com>
On Tue, 17 Aug 2010 14:37:44 +0800
Changli Gao <xiaosuo@gmail.com> wrote:
> TIMER_INITIALIZER() should initialize the field slack of timer_list as
> __init_timer() does.
>
So it should.
> ---
> include/linux/timer.h | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/include/linux/timer.h b/include/linux/timer.h
> index 38cf093..81de484 100644
> --- a/include/linux/timer.h
> +++ b/include/linux/timer.h
> @@ -54,6 +54,7 @@ extern struct tvec_base boot_tvec_bases;
> .expires = (_expires), \
> .data = (_data), \
> .base = &boot_tvec_bases, \
> + .slack = -1, \
> __TIMER_LOCKDEP_MAP_INITIALIZER( \
> __FILE__ ":" __stringify(__LINE__)) \
> }
I wonder what the runtime effects of this change are. Methinks we were
wasting a few cycles in apply_slack()?
prev parent reply other threads:[~2010-08-19 23:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 6:37 Changli Gao
2010-08-19 23:55 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819165522.7e608703.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®