From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753266Ab0HWX5q (ORCPT ); Mon, 23 Aug 2010 19:57:46 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:38141 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752002Ab0HWX5o (ORCPT ); Mon, 23 Aug 2010 19:57:44 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Tue, 24 Aug 2010 08:52:43 +0900 From: KAMEZAWA Hiroyuki To: Daisuke Nishimura Cc: linux-mm@kvack.org, "balbir@linux.vnet.ibm.com" , gthelen@google.com, m-ikeda@ds.jp.nec.com, "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , kamezawa.hiroyuki@gmail.com Subject: Re: [PATCH] memcg: use ID in page_cgroup Message-Id: <20100824085243.8dd3c8de.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100823143237.b7822ffc.nishimura@mxp.nes.nec.co.jp> References: <20100820185552.426ff12e.kamezawa.hiroyu@jp.fujitsu.com> <20100820190132.43684862.kamezawa.hiroyu@jp.fujitsu.com> <20100823143237.b7822ffc.nishimura@mxp.nes.nec.co.jp> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Aug 2010 14:32:37 +0900 Daisuke Nishimura wrote: > On Fri, 20 Aug 2010 19:01:32 +0900 > KAMEZAWA Hiroyuki wrote: > > > > > I have an idea to remove page_cgroup->page pointer, 8bytes reduction per page. > > But it will be after this work. > Another off topic. I think we can reduce the size of mem_cgroup by packing > some boolean members into one "unsinged long flags". > I'll use "flags" to remove struct page pointer. > > @@ -300,12 +300,13 @@ static atomic_t mem_cgroup_num; > > #define NR_MEMCG_GROUPS (CONFIG_MEM_CGROUP_MAX_GROUPS + 1) > > static struct mem_cgroup *mem_cgroups[NR_MEMCG_GROUPS] __read_mostly; > > > > -/* Must be called under rcu_read_lock */ > > -static struct mem_cgroup *id_to_memcg(unsigned short id) > > +/* Must be called under rcu_read_lock, set safe==true if under lock */ > Do you mean, "Set safe==true if we can ensure by some locks that the id can be > safely dereferenced without rcu_read_lock", right ? > yes. that's just for rcu_deerference_check(). > > +static struct mem_cgroup *id_to_memcg(unsigned short id, bool safe) > > { > > struct mem_cgroup *ret; > > /* see mem_cgroup_free() */ > > - ret = rcu_dereference_check(mem_cgroups[id], rch_read_lock_held()); > > + ret = rcu_dereference_check(mem_cgroups[id], > > + rch_read_lock_held() || safe); > > if (likely(ret && ret->valid)) > > return ret; > > return NULL; > > (snip) > > @@ -723,6 +729,11 @@ static inline bool mem_cgroup_is_root(st > > return (mem == root_mem_cgroup); > > } > > > > +static inline bool mem_cgroup_is_rootid(unsigned short id) > > +{ > > + return (id == 1); > > +} > > + > It might be better to add > > BUG_ON(newid->id != 1) > > in cgroup.c::cgroup_init_idr(). > Why ?? Thanks, -Kame