mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] s390: Fix prototype for execve
Date: Wed, 25 Aug 2010 07:32:43 +0200	[thread overview]
Message-ID: <20100825053242.GA2153@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <4C73F25D.5010205@suse.com>

On Tue, Aug 24, 2010 at 12:25:01PM -0400, Jeff Mahoney wrote:
>  Commit d7627467b7a8dd6944885290a03a07ceb28c10eb constified the
>  arguments to execve but missed the s390 prototype.
> 
>  This patch fixes it up.
> 
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> ---
> 
>  arch/s390/kernel/entry.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/s390/kernel/entry.h
> +++ b/arch/s390/kernel/entry.h
> @@ -42,8 +42,8 @@ long sys_clone(unsigned long newsp, unsi
>  	       int __user *parent_tidptr, int __user *child_tidptr);
>  long sys_vfork(void);
>  void execve_tail(void);
> -long sys_execve(const char __user *name, char __user * __user *argv,
> -		char __user * __user *envp);
> +long sys_execve(const char __user *name, const char __user *const __user *argv,
> +		const char __user *const __user *envp);
>  long sys_sigsuspend(int history0, int history1, old_sigset_t mask);
>  long sys_sigaction(int sig, const struct old_sigaction __user *act,
>  		   struct old_sigaction __user *oact);

A similar patch just got merged. Thanks!

      parent reply	other threads:[~2010-08-25  5:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24 16:25 Jeff Mahoney
2010-08-24 19:58 ` David Howells
2010-08-25  5:32 ` Heiko Carstens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100825053242.GA2153@osiris.boeblingen.de.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=dhowells@redhat.com \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome