From: Miklos Szeredi <miklos@szeredi.hu>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: vaurora@redhat.com, neilb@suse.de, viro@zeniv.linux.org.uk,
jblunck@suse.de, hch@infradead.org
Subject: [PATCH 3/5] vfs: add flag to allow rename to same inode
Date: Thu, 26 Aug 2010 20:33:43 +0200 [thread overview]
Message-ID: <20100826183503.586646860@szeredi.hu> (raw)
In-Reply-To: <20100826183340.027591901@szeredi.hu>
[-- Attachment #1: vfs-fs_rename_self_allow.patch --]
[-- Type: text/plain, Size: 1523 bytes --]
From: Miklos Szeredi <mszeredi@suse.cz>
Hybrid union filesystem uses dummy inodes for non-directories. Allow
rename to work in this case despite the inode being the same.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
---
fs/namei.c | 4 +++-
include/linux/fs.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6/include/linux/fs.h
===================================================================
--- linux-2.6.orig/include/linux/fs.h 2010-08-25 14:19:34.000000000 +0200
+++ linux-2.6/include/linux/fs.h 2010-08-25 14:19:53.000000000 +0200
@@ -179,6 +179,7 @@ struct inodes_stat_t {
#define FS_RENAME_DOES_D_MOVE 32768 /* FS will handle d_move()
* during rename() internally.
*/
+#define FS_RENAME_SELF_ALLOW 65536 /* Allow rename to same inode */
/*
* These are the fs-independent mount-flags: up to 32 flags are supported
Index: linux-2.6/fs/namei.c
===================================================================
--- linux-2.6.orig/fs/namei.c 2010-08-25 10:19:53.000000000 +0200
+++ linux-2.6/fs/namei.c 2010-08-25 14:22:56.000000000 +0200
@@ -2620,8 +2620,10 @@ int vfs_rename(struct inode *old_dir, st
int is_dir = S_ISDIR(old_dentry->d_inode->i_mode);
const unsigned char *old_name;
- if (old_dentry->d_inode == new_dentry->d_inode)
+ if (old_dentry->d_inode == new_dentry->d_inode &&
+ !(old_dir->i_sb->s_type->fs_flags & FS_RENAME_SELF_ALLOW)) {
return 0;
+ }
error = may_delete(old_dir, old_dentry, is_dir);
if (error)
--
next prev parent reply other threads:[~2010-08-26 18:35 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 18:33 [PATCH 0/5] hybrid union filesystem prototype Miklos Szeredi
2010-08-26 18:33 ` [PATCH 1/5] vfs: implement open "forwarding" Miklos Szeredi
2010-08-26 18:33 ` [PATCH 2/5] vfs: make i_op->permission take a dentry instead of an inode Miklos Szeredi
2010-08-26 20:24 ` David P. Quigley
2010-08-27 4:11 ` Neil Brown
2010-08-27 18:13 ` David P. Quigley
2010-08-27 19:21 ` Valerie Aurora
2010-08-27 18:31 ` David P. Quigley
2010-08-26 18:33 ` Miklos Szeredi [this message]
2010-08-26 18:33 ` [PATCH 4/5] vfs: export do_splice_direct() to modules Miklos Szeredi
2010-08-26 18:33 ` [PATCH 5/5] union: hybrid union filesystem prototype Miklos Szeredi
2010-09-01 21:42 ` Valerie Aurora
2010-09-02 9:19 ` Miklos Szeredi
2010-09-02 21:33 ` Valerie Aurora
2010-09-03 5:10 ` Neil Brown
2010-09-03 9:16 ` Miklos Szeredi
2010-09-09 16:02 ` David P. Quigley
2010-09-03 8:52 ` Miklos Szeredi
2010-09-02 21:42 ` Valerie Aurora
2010-09-03 12:31 ` Miklos Szeredi
2010-08-27 7:05 ` [PATCH 0/5] " Neil Brown
2010-08-27 8:47 ` Miklos Szeredi
2010-08-27 11:35 ` Neil Brown
2010-08-27 16:53 ` Miklos Szeredi
2010-08-29 4:42 ` Neil Brown
2010-08-30 10:18 ` Miklos Szeredi
2010-08-30 11:40 ` Neil Brown
2010-08-30 12:20 ` Miklos Szeredi
2010-08-31 19:18 ` Valerie Aurora
2010-08-31 20:19 ` Trond Myklebust
2010-09-01 1:56 ` Valerie Aurora
2010-09-01 4:04 ` Trond Myklebust
2010-09-01 4:33 ` Neil Brown
2010-09-01 20:11 ` Miklos Szeredi
2010-08-31 19:29 ` Valerie Aurora
2010-09-02 13:15 ` Jan Engelhardt
2010-09-02 13:32 ` Neil Brown
2010-09-02 14:25 ` Jan Engelhardt
2010-09-02 14:28 ` Miklos Szeredi
2010-09-08 19:47 ` David P. Quigley
2010-09-23 13:18 ` Jan Engelhardt
2010-09-23 19:22 ` Valerie Aurora
2010-08-30 18:38 ` Valerie Aurora
2010-08-30 23:12 ` Neil Brown
2010-08-31 11:00 ` Miklos Szeredi
2010-08-31 11:24 ` Neil Brown
2010-08-31 15:05 ` Kyle Moffett
2010-08-31 20:36 ` Valerie Aurora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100826183503.586646860@szeredi.hu \
--to=miklos@szeredi.hu \
--cc=hch@infradead.org \
--cc=jblunck@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=vaurora@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®