From: Fenghua Yu <fenghua.yu@intel.com>
To: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Cc: "Yu, Fenghua" <fenghua.yu@intel.com>,
mingo Redhat <mingo@redhat.com>,
"Brown, Len" <len.brown@intel.com>,
Guenter Roeck <guenter.roeck@ericsson.com>,
"H. Peter Anvin" <hpa@linux.jf.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
LKLM <linux-kernel@vger.kernel.org>
Subject: Re: [Patch-next] therm_throt.c: fix missing { and }.
Date: Thu, 26 Aug 2010 13:51:25 -0700 [thread overview]
Message-ID: <20100826205125.GA16468@fenghua-desk.sc.intel.com> (raw)
In-Reply-To: <4C7625D1.4060201@np.css.fujitsu.com>
On Thu, Aug 26, 2010 at 01:29:05AM -0700, Jin Dongming wrote:
> When the feature PTS is not supported by CPU, the sysfile
> package_power_limit_count for package should not be generated.
>
> This patch is used for fixing missing { and }. But I have not confirmed
> this patch because I don't have such machine.
>
> Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
> ---
> arch/x86/kernel/cpu/mcheck/therm_throt.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> index d9368ee..169d880 100644
> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> @@ -216,7 +216,7 @@ static __cpuinit int thermal_throttle_add_dev(struct sys_device *sys_dev,
> err = sysfs_add_file_to_group(&sys_dev->kobj,
> &attr_core_power_limit_count.attr,
> thermal_attr_group.name);
> - if (cpu_has(c, X86_FEATURE_PTS))
> + if (cpu_has(c, X86_FEATURE_PTS)) {
> err = sysfs_add_file_to_group(&sys_dev->kobj,
> &attr_package_throttle_count.attr,
> thermal_attr_group.name);
> @@ -224,6 +224,7 @@ static __cpuinit int thermal_throttle_add_dev(struct sys_device *sys_dev,
> err = sysfs_add_file_to_group(&sys_dev->kobj,
> &attr_package_power_limit_count.attr,
> thermal_attr_group.name);
> + }
>
> return err;
> }
> --
> 1.7.1.1
>
Reviewed-by: Fenghua Yu <fenghua.yu@initel.com>
next prev parent reply other threads:[~2010-08-26 21:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 2:39 [Patch-next] Package Level Power limit: fix the generation of package_power_limit_count sysfile Jin Dongming
2010-08-26 6:08 ` Fenghua Yu
2010-08-26 8:29 ` [Patch-next] therm_throt.c: fix missing { and } Jin Dongming
2010-08-26 20:51 ` Fenghua Yu [this message]
2010-08-27 13:20 ` [lm-sensors] " Jean Delvare
2010-08-30 7:58 ` Jin Dongming
2010-08-30 19:15 ` Yu, Fenghua
2010-08-31 0:55 ` [Patch-next] Trival fixes in thermal_throttle_add_dev() Jin Dongming
2010-08-31 1:02 ` Fenghua Yu
2010-08-31 7:07 ` Jean Delvare
2010-08-31 17:04 ` Fenghua Yu
2010-08-31 19:30 ` Jean Delvare
2010-09-02 0:36 ` Jin Dongming
2010-08-31 6:55 ` Jean Delvare
2010-10-08 10:54 ` [tip:x86/urgent] x86, mce, therm_throt.c: Fix missing curly braces in error handling logic tip-bot for Jin Dongming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100826205125.GA16468@fenghua-desk.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=guenter.roeck@ericsson.com \
--cc=hpa@linux.jf.intel.com \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mingo@redhat.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®