From: Andrew Morton <akpm@linux-foundation.org>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
dtor@mail.ru, adobriyan@gmail.com, tj@kernel.org,
Eric Miao <eric.y.miao@gmail.com>
Subject: Re: [PATCH] UCB1400: Pass ucb1400-gpio data through ac97 bus
Date: Thu, 26 Aug 2010 23:14:19 -0700 [thread overview]
Message-ID: <20100826231419.fff73529.akpm@linux-foundation.org> (raw)
In-Reply-To: <201008270750.38118.marek.vasut@gmail.com>
On Fri, 27 Aug 2010 07:50:37 +0200 Marek Vasut <marek.vasut@gmail.com> wrote:
> Dne P__ 27. srpna 2010 01:07:36 Andrew Morton napsal(a):
> > On Mon, 9 Aug 2010 06:43:14 +0200
> >
> > Marek Vasut <marek.vasut@gmail.com> wrote:
> > > Dne Po 9. srpna 2010 06:16:34 Marek Vasut napsal(a):
> > > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> >
> > Please don't send unchangelogged patches.
>
> Unchangelogged? What do you mean ?
Patches which don't have any changelog. This patch was sent with no
covering explanation.
> >
> > The title tells us what the patch does but provides no hint as to why
> > it does it.
As I indicated. The title tells us what the patch does but didn't tell
us *why* it does it. Apparently it is preparatory work for some other
patch?
> > > > ---
> > > >
> > > > drivers/gpio/ucb1400_gpio.c | 19 ++++++-------------
> > > > drivers/mfd/ucb1400_core.c | 5 +++++
> > > > include/linux/ucb1400.h | 19 ++++++-------------
> > > > 3 files changed, 17 insertions(+), 26 deletions(-)
> > >
> > > Ah right, guys, if possible, let this go through Eric Miao's tree (as I
> > > have changes that depend on this). Thanks!
> >
> > He's probably unaware of the patch. Let's cc him.
>
> I have this one in my tree and I sent it to Eric as a part of larger patchset.
Recently, I assume - it wasn't in this morning's linux-next.
next prev parent reply other threads:[~2010-08-27 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 4:16 Marek Vasut
2010-08-09 4:43 ` Marek Vasut
2010-08-26 23:07 ` Andrew Morton
2010-08-27 5:50 ` Marek Vasut
2010-08-27 6:14 ` Andrew Morton [this message]
2010-08-27 6:17 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100826231419.fff73529.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=dtor@mail.ru \
--cc=eric.y.miao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=sameo@linux.intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome