From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752727Ab0H0Mhp (ORCPT ); Fri, 27 Aug 2010 08:37:45 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:41334 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569Ab0H0Mhm (ORCPT ); Fri, 27 Aug 2010 08:37:42 -0400 Date: Fri, 27 Aug 2010 08:37:19 -0400 From: Neil Horman To: Koki Sanagi Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, kaneshige.kenji@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, kosaki.motohiro@jp.fujitsu.com, laijs@cn.fujitsu.com, scott.a.mcmillan@intel.com, rostedt@goodmis.org, eric.dumazet@gmail.com, fweisbec@gmail.com, mathieu.desnoyers@polymtl.ca Subject: Re: [RFC PATCH v4 1/5] irq: add tracepoint to softirq_raise Message-ID: <20100827123719.GA17607@hmsreliant.think-freely.org> References: <4C4FCDA1.3000803@jp.fujitsu.com> <4C4FCE31.5090004@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C4FCE31.5090004@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 28, 2010 at 03:29:05PM +0900, Koki Sanagi wrote: > CHANGE-LOG since v3: > -change arguments of softirq tracepoint into original one. > > From: Lai Jiangshan > > Add a tracepoint for tracing when softirq action is raised. > > It and the existed tracepoints complete softirq's tracepoints: > softirq_raise, softirq_entry and softirq_exit. > > And when this tracepoint is used in combination with > the softirq_entry tracepoint we can determine > the softirq raise latency. > > Signed-off-by: Lai Jiangshan > Acked-by: Mathieu Desnoyers > Acked-by: Frederic Weisbecker > Sorry its taken me awhile to get back to these, I've been on PTO Acked-by: Neil Horman > [ factorize softirq events with DECLARE_EVENT_CLASS ] > Signed-off-by: Koki Sanagi > --- > include/linux/interrupt.h | 8 +++++++- > include/trace/events/irq.h | 26 ++++++++++++++++++++++++-- > 2 files changed, 31 insertions(+), 3 deletions(-) > > diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h > index c233113..5460db4 100644 > --- a/include/linux/interrupt.h > +++ b/include/linux/interrupt.h > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > > /* > * These correspond to the IORESOURCE_IRQ_* defines in > @@ -402,7 +403,12 @@ asmlinkage void do_softirq(void); > asmlinkage void __do_softirq(void); > extern void open_softirq(int nr, void (*action)(struct softirq_action *)); > extern void softirq_init(void); > -#define __raise_softirq_irqoff(nr) do { or_softirq_pending(1UL << (nr)); } while (0) > +static inline void __raise_softirq_irqoff(unsigned int nr) > +{ > + trace_softirq_raise((struct softirq_action *)&nr, NULL); > + or_softirq_pending(1UL << nr); > +} > + > extern void raise_softirq_irqoff(unsigned int nr); > extern void raise_softirq(unsigned int nr); > extern void wakeup_softirqd(void); > diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h > index 0e4cfb6..3ddda02 100644 > --- a/include/trace/events/irq.h > +++ b/include/trace/events/irq.h > @@ -5,7 +5,9 @@ > #define _TRACE_IRQ_H > > #include > -#include > + > +struct irqaction; > +struct softirq_action; > > #define softirq_name(sirq) { sirq##_SOFTIRQ, #sirq } > #define show_softirq_name(val) \ > @@ -93,7 +95,10 @@ DECLARE_EVENT_CLASS(softirq, > ), > > TP_fast_assign( > - __entry->vec = (int)(h - vec); > + if (vec) > + __entry->vec = (int)(h - vec); > + else > + __entry->vec = *((int *)h); > ), > > TP_printk("vec=%d [action=%s]", __entry->vec, > @@ -136,6 +141,23 @@ DEFINE_EVENT(softirq, softirq_exit, > TP_ARGS(h, vec) > ); > > +/** > + * softirq_raise - called immediately when a softirq is raised > + * @h: pointer to struct softirq_action > + * @vec: pointer to first struct softirq_action in softirq_vec array > + * > + * The @h parameter contains a pointer to the softirq vector number which is > + * raised. @vec is NULL and it means @h includes vector number not > + * softirq_action. When used in combination with the softirq_entry tracepoint > + * we can determine the softirq raise latency. > + */ > +DEFINE_EVENT(softirq, softirq_raise, > + > + TP_PROTO(struct softirq_action *h, struct softirq_action *vec), > + > + TP_ARGS(h, vec) > +); > + > #endif /* _TRACE_IRQ_H */ > > /* This part must be outside protection */ > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >