From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754264Ab0H0Okp (ORCPT ); Fri, 27 Aug 2010 10:40:45 -0400 Received: from pfepa.post.tele.dk ([195.41.46.235]:56894 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754096Ab0H0Okn (ORCPT ); Fri, 27 Aug 2010 10:40:43 -0400 Date: Fri, 27 Aug 2010 16:40:39 +0200 From: Sam Ravnborg To: Konrad Rzeszutek Wilk Cc: hpa@zytor.com, fujita.tomonori@lab.ntt.co.jp, linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH 01/10] x86/iommu: Add IOMMU_INIT macros, .iommu_table section, and iommu_table_entry structure. Message-ID: <20100827144039.GA7438@merkur.ravnborg.org> References: <1282845485-8991-1-git-send-email-konrad.wilk@oracle.com> <1282845485-8991-2-git-send-email-konrad.wilk@oracle.com> <20100826181913.GA5947@merkur.ravnborg.org> <20100827143844.GA32547@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100827143844.GA32547@phenom.dumpdata.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 27, 2010 at 10:38:44AM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Aug 26, 2010 at 08:19:13PM +0200, Sam Ravnborg wrote: > > > diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S > > > index d0bb522..b92e040 100644 > > > --- a/arch/x86/kernel/vmlinux.lds.S > > > +++ b/arch/x86/kernel/vmlinux.lds.S > > > @@ -260,6 +260,13 @@ SECTIONS > > > *(.altinstr_replacement) > > > } > > > > > > + .iommu_table : AT(ADDR(.iommu_table) - LOAD_OFFSET) { > > > + __iommu_table = .; > > > + *(.iommu_table) > > > + . = ALIGN(8); > > > + __iommu_table_end = .; > > > + } > > > + > > > > So we have yet another magic section in vmlinux.lds.S > > A nice comemnt that expalins what this is used for and why > > it is discardable etc. would be nice. > > > > Lots of magic sections in same file miss this, > > but thats not an example to follwow. > > Sure. Will provide one and also explain the other sections that I am > familiar with. Appreciated - thanks! Sam