mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Neil Munro <neilmunro@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 985/985] Staging: RT2860: Fixed All coding style errors in rt_linux.h
Date: Tue, 31 Aug 2010 11:56:11 -0700	[thread overview]
Message-ID: <20100831185611.GA28510@kroah.com> (raw)
In-Reply-To: <1281091790-3721-1-git-send-email-neilmunro@gmail.com>

On Fri, Aug 06, 2010 at 11:49:50AM +0100, Neil Munro wrote:
> Removed all coding style errors from this file the warnings however remain.
> 
> Signed-off-by: Neil Munro <neilmunro@gmail.com>

This patch breaks the build:
drivers/staging/rt2860/sta/rtmp_data.c: In function ‘STASendPackets’:
drivers/staging/rt2860/sta/rtmp_data.c:885:5: error: ‘_p’ undeclared (first use in this function)
drivers/staging/rt2860/sta/rtmp_data.c:885:5: note: each undeclared identifier is reported only once for each function it appears in
drivers/staging/rt2860/sta/rtmp_data.c:885:5: error: ‘_status’ undeclared (first use in this function)
drivers/staging/rt2860/sta/rtmp_data.c:885:5: warning: left-hand operand of comma expression has no effect
drivers/staging/rt2860/sta/rtmp_data.c:885:5: error: expected ‘;’ before ‘do’

Please always test your patches before you send them out.

I've dropped this one.

thanks,

greg k-h

      reply	other threads:[~2010-08-31 19:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-06 10:49 [PATCH 985/985] Staging: RT2860: Fixed All " Neil Munro
2010-08-31 18:56 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100831185611.GA28510@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilmunro@gmail.com \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome