From: Greg KH <greg@kroah.com>
To: T Dent <tdent48227@gmail.com>
Cc: linux-kernel@vger.kernel.org, bzolnier@gmail.com,
Larry.Finger@lwfinger.net, joe@perches.com,
pshah.mumbai@gmail.com
Subject: Re: [PATCH 1/8] Staging: rtl8187se: r8180: fixed alot checkpatch.pl issues
Date: Tue, 31 Aug 2010 15:31:29 -0700 [thread overview]
Message-ID: <20100831223129.GA316@kroah.com> (raw)
In-Reply-To: <AANLkTimEdzcqEv1SCMWyftCwGU-==+vMH8-uuzAHLOM+@mail.gmail.com>
On Fri, Aug 20, 2010 at 05:00:13PM -0400, T Dent wrote:
> >From 73dfcd936fcacb6f1dce184e21b177c9fa4797d5 Mon Sep 17 00:00:00 2001
> From: Tracey Dent <Tdent48227@gmail.com>
> Date: Thu, 19 Aug 2010 16:13:48 -0400
> Subject: [PATCH 1/8] Staging: rtl8187se: r8180: fixed alot checkpatch.pl issues
>
> Fixed numerous coding style issues using checkpatch.pl
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
> drivers/staging/rtl8187se/r8180.h | 537 ++++++++++++++++++-------------------
> 1 files changed, 265 insertions(+), 272 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180.h
> b/drivers/staging/rtl8187se/r8180.h
> index d15bdf6..c5b1cba 100644
> --- a/drivers/staging/rtl8187se/r8180.h
> +++ b/drivers/staging/rtl8187se/r8180.h
> @@ -1,18 +1,18 @@
> /*
> - This is part of rtl8180 OpenSource driver.
> - Copyright (C) Andrea Merello 2004-2005 <andreamrl@tiscali.it>
> - Released under the terms of GPL (General Public Licence)
> + This is part of rtl8180 OpenSource driver.
> + Copyright (C) Andrea Merello 2004-2005 <andreamrl@tiscali.it>
> + Released under the terms of GPL (General Public Licence)
>
> - Parts of this driver are based on the GPL part of the
> - official realtek driver
> + Parts of this driver are based on the GPL part of the
> + official realtek driver
>
> - Parts of this driver are based on the rtl8180 driver skeleton
> - from Patric Schenke & Andres Salomon
> + Parts of this driver are based on the rtl8180 driver skeleton
> + from Patric Schenke & Andres Salomon
>
> - Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver
> + Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver
>
> - We want to tanks the Authors of those projects and the Ndiswrapper
> - project Authors.
> + We want to tanks the Authors of those projects and the Ndiswrapper
> + project Authors.
> */
>
> #ifndef R8180H
> @@ -20,13 +20,13 @@
>
>
> #define RTL8180_MODULE_NAME "r8180"
> -#define DMESG(x,a...) printk(KERN_INFO RTL8180_MODULE_NAME ": " x "\n", ## a)
> -#define DMESGW(x,a...) printk(KERN_WARNING RTL8180_MODULE_NAME ":
> WW:" x "\n", ## a)
Your patches are line-wrapped and can't be applied :(
Care to fix your email client and resend them?
thanks,
greg k-h
prev parent reply other threads:[~2010-08-31 22:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 21:00 T Dent
2010-08-31 22:31 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831223129.GA316@kroah.com \
--to=greg@kroah.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bzolnier@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pshah.mumbai@gmail.com \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome