From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jacob Tanenbaum <Jacob.Tanenbaum@logicpd.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Low-level init of hsmmc controller for LogicPD's OMAP3530LV SOM and OMAP 35x Torpedo dev boards
Date: Thu, 2 Sep 2010 14:22:11 +0100 [thread overview]
Message-ID: <20100902132211.GF26319@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1282708420-26418-2-git-send-email-Jacob.Tanenbaum@logicpd.com>
On Tue, Aug 24, 2010 at 11:53:38PM -0400, Jacob Tanenbaum wrote:
> From: jake <jake@Glados.(none)>
Not a valid address... please fix.
>
> ARM: OMAP3LOGIC: Adding SDMMC support
> Add low-level initialization for hsmmc controller for
> LogicPD's OMAP 3530 LV SOM and OMAP 35x Torpedo board.
>
> Tested against: 81e09f50c93edff607259cbe374a3006c9c5fa74
> Signed-off-by: Jacob Tanenbaum <Jacob.Tanenbaum@logicpd.com>
I'm confused why these comments are indented.
> +static void __init board_mmc_init(void)
> +{
> + /* OMAP3530 LV SOM board */
> + if (machine_is_omap3530_lv_som()) {
> + board_mmc_info[0].gpio_cd = OMAP3530_LV_SOM_MMC_GPIO_CD;
> + board_mmc_info[0].gpio_wp = OMAP3530_LV_SOM_MMC_GPIO_WP;
> + omap_mux_init_signal("gpio_110", OMAP_PIN_OUTPUT);
> + omap_mux_init_signal("gpio_126", OMAP_PIN_OUTPUT);
> +
> +
> + /* OMAP3 Torpedo board */
missing tab?
> + } else if (machine_is_omap3_torpedo()) {
> + board_mmc_info[0].gpio_cd = OMAP3_TORPEDO_MMC_GPIO_CD;
> + omap_mux_init_signal("gpio_127", OMAP_PIN_OUTPUT);
> + /* unsupported board */
missing tab?
> + } else {
> + printk(KERN_ERR "%s(): unknown machine type\n", __func__);
> + return;
missing tab?
next prev parent reply other threads:[~2010-09-02 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 3:53 [PATCH 1/4] initial support for LogicPD's OMAP3530LV SOM and OMAP35x " Jacob Tanenbaum
2010-08-25 3:53 ` [PATCH 2/4] Low-level init of hsmmc controller for LogicPD's OMAP3530LV SOM and OMAP 35x " Jacob Tanenbaum
2010-08-25 3:53 ` [PATCH 3/4] add generic smsc911x support for LogicPD's OMAP 3530LV SOM and Torpedo 35x dev kits Jacob Tanenbaum
2010-08-25 3:53 ` [PATCH 4/4] Enabling Ethernet support for LogicPD's OMAP 3530LV SOM and OMAP 35x Torpedo dev board Jacob Tanenbaum
2010-09-02 13:24 ` Russell King - ARM Linux
2010-09-02 13:22 ` Russell King - ARM Linux [this message]
2010-09-02 13:20 ` [PATCH 1/4] initial support for LogicPD's OMAP3530LV SOM and OMAP35x Torpedo dev boards Russell King - ARM Linux
2010-08-25 3:55 [PATCH 2/4] Low-level init of hsmmc controller for LogicPD's OMAP3530LV SOM and OMAP 35x " Jacob Tanenbaum
2010-09-02 13:24 ` Russell King - ARM Linux
2010-08-25 4:00 Jacob Tanenbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902132211.GF26319@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Jacob.Tanenbaum@logicpd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®